Re: [Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-04 Thread Brian Paul
On 09/03/2012 09:47 PM, Matt Turner wrote: On Mon, Sep 3, 2012 at 12:15 PM, Matt Turner wrote: On Mon, Sep 3, 2012 at 7:13 AM, Brian Paul wrote: From: Brian Paul Since free(NULL) is fine. I think if we want to do this, then we should do it all the way with a Coccinelle semantic patch. I'l

Re: [Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-03 Thread Matt Turner
On Mon, Sep 3, 2012 at 12:15 PM, Matt Turner wrote: > On Mon, Sep 3, 2012 at 7:13 AM, Brian Paul wrote: >> From: Brian Paul >> >> Since free(NULL) is fine. > > I think if we want to do this, then we should do it all the way with a > Coccinelle semantic patch. > > I'll send a patch. Oh, I see yo

Re: [Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-03 Thread Matt Turner
On Mon, Sep 3, 2012 at 7:13 AM, Brian Paul wrote: > From: Brian Paul > > Since free(NULL) is fine. I think if we want to do this, then we should do it all the way with a Coccinelle semantic patch. I'll send a patch. ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-03 Thread Kenneth Graunke
On 09/03/2012 07:13 AM, Brian Paul wrote: > From: Brian Paul > > Since free(NULL) is fine. I vaguely recall something about free(NULL) not being OK with MSVC. I hope I'm wrong about that, though. Assuming there's no problem there, these look good! For the series: Reviewed-by: Kenneth Graunke

[Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-03 Thread Brian Paul
From: Brian Paul Since free(NULL) is fine. --- src/mesa/main/eval.c | 68 + 1 files changed, 24 insertions(+), 44 deletions(-) diff --git a/src/mesa/main/eval.c b/src/mesa/main/eval.c index 0ae349f..7709217 100644 --- a/src/mesa/main/eval.c +++