Re: [Mesa-dev] [PATCH 1/3] llvmpipe: don't store eo as 64bit int

2016-01-04 Thread Brian Paul
Looks OK to me. For the series, Reviewed-by: Brian Paul On 01/02/2016 01:39 PM, srol...@vmware.com wrote: From: Roland Scheidegger eo, just like dcdx and dcdy, cannot overflow 32bit. Store it as unsigned though just in case (it cannot be negative, but in theory twice as big as dcdx or dcdy

[Mesa-dev] [PATCH 1/3] llvmpipe: don't store eo as 64bit int

2016-01-02 Thread sroland
From: Roland Scheidegger eo, just like dcdx and dcdy, cannot overflow 32bit. Store it as unsigned though just in case (it cannot be negative, but in theory twice as big as dcdx or dcdy so this gives it one more bit). This doesn't really change anything, albeit it might help minimally on 32bit arc