Re: [Mesa-dev] [PATCH 1/3] i965: Add a safety check for brw_set_saturate().

Eric Anholt writes: > Kenneth Graunke writes: > >> On 08/08/2012 03:08 PM, Eric Anholt wrote: >>> There is an easy chance for bugs in brw_wm_emit.c, where you would pass 1 >>> << 5 >>> instead of 1, which would get truncated to 0. >>> --- >>> src/mesa/drivers/dri/i965/brw_eu.c |1 + >>> 1

Re: [Mesa-dev] [PATCH 1/3] i965: Add a safety check for brw_set_saturate().

Kenneth Graunke writes: > On 08/08/2012 03:08 PM, Eric Anholt wrote: >> There is an easy chance for bugs in brw_wm_emit.c, where you would pass 1 << >> 5 >> instead of 1, which would get truncated to 0. >> --- >> src/mesa/drivers/dri/i965/brw_eu.c |1 + >> 1 file changed, 1 insertion(+) >>

Re: [Mesa-dev] [PATCH 1/3] i965: Add a safety check for brw_set_saturate().

On 08/08/2012 03:08 PM, Eric Anholt wrote: > There is an easy chance for bugs in brw_wm_emit.c, where you would pass 1 << 5 > instead of 1, which would get truncated to 0. > --- > src/mesa/drivers/dri/i965/brw_eu.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 1/3] i965: Add a safety check for brw_set_saturate().

There is an easy chance for bugs in brw_wm_emit.c, where you would pass 1 << 5 instead of 1, which would get truncated to 0. --- src/mesa/drivers/dri/i965/brw_eu.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/drivers/dri/i965/brw_eu.c index