On Mon, Jan 31, 2011 at 10:20 AM, Julien Cristau wrote:
> On Mon, Jan 31, 2011 at 18:18:22 +0100, Henri Verbeet wrote:
>
>> The attached patch should do.
>
> Looks good to me, thanks.
Committed. Thanks, guys.
-Brian
___
mesa-dev mailing list
mesa-dev@
On Mon, Jan 31, 2011 at 18:18:22 +0100, Henri Verbeet wrote:
> The attached patch should do.
Looks good to me, thanks.
Cheers,
Julien
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
The attached patch should do.
From ab34026885f98914efa6ad671f3446621124a55a Mon Sep 17 00:00:00 2001
From: Henri Verbeet
Date: Mon, 31 Jan 2011 18:09:19 +0100
Subject: [PATCH 1/1] glx: Properly check for a valid fd in dri2CreateScreen().
---
src/glx/dri2_glx.c |4 +++-
1 files changed, 3 ins
On 31 January 2011 17:43, Julien Cristau wrote:
> On Sun, Jan 30, 2011 at 00:00:48 +0100, Henri Verbeet wrote:
>
>> @@ -918,12 +921,15 @@ dri2CreateScreen(int screen, struct glx_display * priv)
>> return &psc->base;
>>
>> handle_error:
>> + if (psc->fd)
>> + close(psc->fd);
>
> 0 is a
On Sun, Jan 30, 2011 at 00:00:48 +0100, Henri Verbeet wrote:
> @@ -918,12 +921,15 @@ dri2CreateScreen(int screen, struct glx_display * priv)
> return &psc->base;
>
> handle_error:
> + if (psc->fd)
> + close(psc->fd);
0 is a valid fd. It might be better to initialize fd to -1 and ch
These look good, Henri. I'll commit them soon.
-Brian
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
---
src/glx/dri2_glx.c | 14 ++
src/glx/glxclient.h |2 ++
src/glx/glxext.c| 28 +---
3 files changed, 29 insertions(+), 15 deletions(-)
diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
index 75b1a10..ab7915c 100644
--- a/src/glx/dri2_glx.c
+++
