Re: [Mesa-dev] [PATCH 1/3] egl/x11: fix use of EGL_BAD_NATIVE_WINDOW

2015-08-04 Thread Frank Binns
On 03/08/15 13:05, Emil Velikov wrote: > On 31 July 2015 at 13:34, Frank Binns wrote: >> On 31/07/15 12:53, Emil Velikov wrote: >>> On 31 July 2015 at 11:02, Frank Binns wrote: Commit 4ed23fd590 introduced some calls to _eglError inappropriately passing it EGL_BAD_NATIVE_WINDOW. This wa

Re: [Mesa-dev] [PATCH 1/3] egl/x11: fix use of EGL_BAD_NATIVE_WINDOW

2015-08-03 Thread Emil Velikov
On 31 July 2015 at 13:34, Frank Binns wrote: > On 31/07/15 12:53, Emil Velikov wrote: >> On 31 July 2015 at 11:02, Frank Binns wrote: >>> Commit 4ed23fd590 introduced some calls to _eglError inappropriately >>> passing it EGL_BAD_NATIVE_WINDOW. This was actually harmless in two of the >>> cases a

Re: [Mesa-dev] [PATCH 1/3] egl/x11: fix use of EGL_BAD_NATIVE_WINDOW

2015-07-31 Thread Frank Binns
On 31/07/15 12:53, Emil Velikov wrote: > On 31 July 2015 at 11:02, Frank Binns wrote: >> Commit 4ed23fd590 introduced some calls to _eglError inappropriately >> passing it EGL_BAD_NATIVE_WINDOW. This was actually harmless in two of the >> cases as _eglError gets called later on with a more appro

Re: [Mesa-dev] [PATCH 1/3] egl/x11: fix use of EGL_BAD_NATIVE_WINDOW

2015-07-31 Thread Emil Velikov
On 31 July 2015 at 11:02, Frank Binns wrote: > Commit 4ed23fd590 introduced some calls to _eglError inappropriately > passing it EGL_BAD_NATIVE_WINDOW. This was actually harmless in two of the > cases as _eglError gets called later on with a more appropriate error code > but (just to be safe) swit

[Mesa-dev] [PATCH 1/3] egl/x11: fix use of EGL_BAD_NATIVE_WINDOW

2015-07-31 Thread Frank Binns
Commit 4ed23fd590 introduced some calls to _eglError inappropriately passing it EGL_BAD_NATIVE_WINDOW. This was actually harmless in two of the cases as _eglError gets called later on with a more appropriate error code but (just to be safe) switch these to _eglLog calls instead. In the remaining ca