Re: [Mesa-dev] [PATCH 1/2] util: import cache.c/h from glsl

2016-11-15 Thread Emil Velikov
On 15 November 2016 at 19:07, Marek Olšák wrote: > From: Marek Olšák > > It's not dependent on GLSL and it can be useful for shader caches that don't > deal with GLSL. > > v2: address review comments Thank you ! > --- > configure.ac | 4 > src/compiler/

[Mesa-dev] [PATCH 1/2] util: import cache.c/h from glsl

2016-11-15 Thread Marek Olšák
From: Marek Olšák It's not dependent on GLSL and it can be useful for shader caches that don't deal with GLSL. v2: address review comments --- configure.ac | 4 src/compiler/Makefile.glsl.am| 4 src/compiler/Makefile.sources

Re: [Mesa-dev] [PATCH 1/2] util: import cache.c/h from glsl

2016-11-14 Thread Emil Velikov
Hi Marek, Please mention the reason behind the move - afaict it's not being used in 2/2. I'm have no objection against the move. There's a few comments below - feel free to squash those here or address as follow-up(s). On 13 November 2016 at 16:05, Marek Olšák wrote: > -if ENABLE_SHADER_CACHE

[Mesa-dev] [PATCH 1/2] util: import cache.c/h from glsl

2016-11-13 Thread Marek Olšák
From: Marek Olšák --- src/compiler/Makefile.glsl.am| 4 src/compiler/Makefile.sources| 4 src/compiler/glsl/tests/cache_test.c | 2 +- src/util/Makefile.sources| 2 ++ src/{compiler/glsl/cache.c => util/dis