Re: [Mesa-dev] [PATCH 1/2] util: Make unreachable at least be an assert

2014-12-05 Thread Ian Romanick
On 12/05/2014 01:54 PM, Ian Romanick wrote: > On 12/05/2014 01:50 PM, Matt Turner wrote: >> On Fri, Dec 5, 2014 at 1:48 PM, Ian Romanick wrote: >>> On 12/05/2014 01:42 PM, Matt Turner wrote: On Fri, Dec 5, 2014 at 1:25 PM, Ian Romanick wrote: > On 12/05/2014 01:17 PM, Carl Worth wrote: >

Re: [Mesa-dev] [PATCH 1/2] util: Make unreachable at least be an assert

2014-12-05 Thread Ian Romanick
On 12/05/2014 01:50 PM, Matt Turner wrote: > On Fri, Dec 5, 2014 at 1:48 PM, Ian Romanick wrote: >> On 12/05/2014 01:42 PM, Matt Turner wrote: >>> On Fri, Dec 5, 2014 at 1:25 PM, Ian Romanick wrote: On 12/05/2014 01:17 PM, Carl Worth wrote: > Previously, if __builtin_unreachable() was un

Re: [Mesa-dev] [PATCH 1/2] util: Make unreachable at least be an assert

2014-12-05 Thread Matt Turner
On Fri, Dec 5, 2014 at 1:48 PM, Ian Romanick wrote: > On 12/05/2014 01:42 PM, Matt Turner wrote: >> On Fri, Dec 5, 2014 at 1:25 PM, Ian Romanick wrote: >>> On 12/05/2014 01:17 PM, Carl Worth wrote: Previously, if __builtin_unreachable() was unavailable, the unreachable macro was defined

Re: [Mesa-dev] [PATCH 1/2] util: Make unreachable at least be an assert

2014-12-05 Thread Ian Romanick
On 12/05/2014 01:42 PM, Matt Turner wrote: > On Fri, Dec 5, 2014 at 1:25 PM, Ian Romanick wrote: >> On 12/05/2014 01:17 PM, Carl Worth wrote: >>> Previously, if __builtin_unreachable() was unavailable, the >>> unreachable macro was defined to do nothing. We do better here, by at >>> least still ma

Re: [Mesa-dev] [PATCH 1/2] util: Make unreachable at least be an assert

2014-12-05 Thread Matt Turner
On Fri, Dec 5, 2014 at 1:25 PM, Ian Romanick wrote: > On 12/05/2014 01:17 PM, Carl Worth wrote: >> Previously, if __builtin_unreachable() was unavailable, the >> unreachable macro was defined to do nothing. We do better here, by at >> least still making it an assert. >> --- >> src/util/macros.h |

Re: [Mesa-dev] [PATCH 1/2] util: Make unreachable at least be an assert

2014-12-05 Thread Ian Romanick
On 12/05/2014 01:17 PM, Carl Worth wrote: > Previously, if __builtin_unreachable() was unavailable, the > unreachable macro was defined to do nothing. We do better here, by at > least still making it an assert. > --- > src/util/macros.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[Mesa-dev] [PATCH 1/2] util: Make unreachable at least be an assert

2014-12-05 Thread Carl Worth
Previously, if __builtin_unreachable() was unavailable, the unreachable macro was defined to do nothing. We do better here, by at least still making it an assert. --- src/util/macros.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/macros.h b/src/util/macros.h index 5