Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-17 Thread Jonathan Gray
On Fri, Feb 17, 2017 at 08:30:17AM -0800, Matt Turner wrote: > On Fri, Feb 17, 2017 at 5:39 AM, Emil Velikov > wrote: > > On 17 February 2017 at 01:10, Jonathan Gray wrote: > >> On Thu, Feb 16, 2017 at 04:25:02PM +, Emil Velikov wrote: > >>> On 16 February 2017 at 14:23, Jonathan Gray wrote

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-17 Thread Matt Turner
On Fri, Feb 17, 2017 at 5:39 AM, Emil Velikov wrote: > On 17 February 2017 at 01:10, Jonathan Gray wrote: >> On Thu, Feb 16, 2017 at 04:25:02PM +, Emil Velikov wrote: >>> On 16 February 2017 at 14:23, Jonathan Gray wrote: >>> > On Wed, Feb 15, 2017 at 11:11:50AM -0800, Matt Turner wrote: >>>

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-17 Thread Emil Velikov
On 17 February 2017 at 01:10, Jonathan Gray wrote: > On Thu, Feb 16, 2017 at 04:25:02PM +, Emil Velikov wrote: >> On 16 February 2017 at 14:23, Jonathan Gray wrote: >> > On Wed, Feb 15, 2017 at 11:11:50AM -0800, Matt Turner wrote: >> >> Provides the ability to read the .note.gnu.build-id sect

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-16 Thread Jonathan Gray
On Thu, Feb 16, 2017 at 04:25:02PM +, Emil Velikov wrote: > On 16 February 2017 at 14:23, Jonathan Gray wrote: > > On Wed, Feb 15, 2017 at 11:11:50AM -0800, Matt Turner wrote: > >> Provides the ability to read the .note.gnu.build-id section of ELF > >> binaries, which is inserted by the --buil

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-16 Thread Emil Velikov
On 16 February 2017 at 14:23, Jonathan Gray wrote: > On Wed, Feb 15, 2017 at 11:11:50AM -0800, Matt Turner wrote: >> Provides the ability to read the .note.gnu.build-id section of ELF >> binaries, which is inserted by the --build-id=... flag to ld. >> >> Reviewed-by: Emil Velikov > > I don't have

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-16 Thread Jonathan Gray
On Wed, Feb 15, 2017 at 11:11:50AM -0800, Matt Turner wrote: > Provides the ability to read the .note.gnu.build-id section of ELF > binaries, which is inserted by the --build-id=... flag to ld. > > Reviewed-by: Emil Velikov I don't have time to dig into details right now but this broke the Mesa

[Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-15 Thread Matt Turner
Provides the ability to read the .note.gnu.build-id section of ELF binaries, which is inserted by the --build-id=... flag to ld. Reviewed-by: Emil Velikov --- configure.ac | 6 +++ src/util/Makefile.sources | 2 + src/util/build_id.c | 109 +

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-15 Thread Jason Ekstrand
On Wed, Feb 15, 2017 at 10:57 AM, Matt Turner wrote: > On Wed, Feb 15, 2017 at 4:03 AM, Emil Velikov > wrote: > > Hi Matt, > > > > Afaics dl_iterate_phdr is available on musl, (some?) BSDs and Solaris > > - thank you for opting for it. > > > > Out of curiosity: > > Have you checked if on those p

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-15 Thread Matt Turner
On Wed, Feb 15, 2017 at 4:03 AM, Emil Velikov wrote: > Hi Matt, > > Afaics dl_iterate_phdr is available on musl, (some?) BSDs and Solaris > - thank you for opting for it. > > Out of curiosity: > Have you checked if on those platforms the "GNU\0" strcmp is > applicable and not another string ? Wort

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-15 Thread Emil Velikov
Hi Matt, Afaics dl_iterate_phdr is available on musl, (some?) BSDs and Solaris - thank you for opting for it. Out of curiosity: Have you checked if on those platforms the "GNU\0" strcmp is applicable and not another string ? Worth adding a note/comment ? On 14 February 2017 at 23:58, Matt Turne

[Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Matt Turner
Provides the ability to read the .note.gnu.build-id section of ELF binaries, which is inserted by the --build-id=... flag to ld. --- configure.ac | 2 + src/util/Makefile.sources | 2 + src/util/build_id.c | 110 ++ src/util/build_

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Matt Turner
On Tue, Feb 14, 2017 at 12:43 PM, Nicholas Miell wrote: > On 02/14/2017 12:30 PM, Chad Versace wrote: >> >> On Tue 14 Feb 2017, Matt Turner wrote: >>> >>> Provides the ability to read the .note.gnu.build-id section of ELF >>> binaries, which is inserted by the --build-id=... flag to ld. >>> --- >>

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Jason Ekstrand
On Tue, Feb 14, 2017 at 11:34 AM, Chad Versace wrote: > On Tue 14 Feb 2017, Matt Turner wrote: > > On Tue, Feb 14, 2017 at 11:21 AM, Matt Turner > wrote: > > > On Tue, Feb 14, 2017 at 11:18 AM, Matt Turner > wrote: > > >> On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand < > ja...@jlekstrand.net

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Nicholas Miell
On 02/14/2017 12:30 PM, Chad Versace wrote: On Tue 14 Feb 2017, Matt Turner wrote: Provides the ability to read the .note.gnu.build-id section of ELF binaries, which is inserted by the --build-id=... flag to ld. --- configure.ac | 2 + src/util/Makefile.sources | 2 + src/util/

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Chad Versace
On Tue 14 Feb 2017, Matt Turner wrote: > Provides the ability to read the .note.gnu.build-id section of ELF > binaries, which is inserted by the --build-id=... flag to ld. > --- > configure.ac | 2 + > src/util/Makefile.sources | 2 + > src/util/build_id.c | 109 > +

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Matt Turner
On Tue, Feb 14, 2017 at 11:39 AM, Kristian H. Kristensen wrote: > Matt Turner writes: >> diff --git a/src/util/build_id.c b/src/util/build_id.c >> new file mode 100644 >> index 000..a2e21b7 >> --- /dev/null >> +++ b/src/util/build_id.c >> @@ -0,0 +1,109 @@ >> +/* >> + * Copyright © 2016 Intel

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Kristian H. Kristensen
Matt Turner writes: > Provides the ability to read the .note.gnu.build-id section of ELF > binaries, which is inserted by the --build-id=... flag to ld. > --- > configure.ac | 2 + > src/util/Makefile.sources | 2 + > src/util/build_id.c | 109 > ++

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Chad Versace
On Tue 14 Feb 2017, Matt Turner wrote: > Provides the ability to read the .note.gnu.build-id section of ELF > binaries, which is inserted by the --build-id=... flag to ld. Heh. Sunday night I wrote a prototype of this myself. I'm strongly in favor of basing Vulkan unique id's on the ELF build-id i

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Chad Versace
On Tue 14 Feb 2017, Matt Turner wrote: > On Tue, Feb 14, 2017 at 11:21 AM, Matt Turner wrote: > > On Tue, Feb 14, 2017 at 11:18 AM, Matt Turner wrote: > >> On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand > >> wrote: > >>> I'm not sure how I feel about the silent fall-backs. At least in the >

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Matt Turner
On Tue, Feb 14, 2017 at 11:21 AM, Matt Turner wrote: > On Tue, Feb 14, 2017 at 11:18 AM, Matt Turner wrote: >> On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand >> wrote: >>> I'm not sure how I feel about the silent fall-backs. At least in the Vulkan >>> driver, we should fail to compile if we

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Matt Turner
On Tue, Feb 14, 2017 at 11:18 AM, Matt Turner wrote: > On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand wrote: >> I'm not sure how I feel about the silent fall-backs. At least in the Vulkan >> driver, we should fail to compile if we can't get build-id. Otherwise, >> you'll end up compiling a dr

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Matt Turner
On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand wrote: > I'm not sure how I feel about the silent fall-backs. At least in the Vulkan > driver, we should fail to compile if we can't get build-id. Otherwise, > you'll end up compiling a driver that will always fail device creation. That was reall

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Jason Ekstrand
On Tue, Feb 14, 2017 at 10:51 AM, Matt Turner wrote: > Provides the ability to read the .note.gnu.build-id section of ELF > binaries, which is inserted by the --build-id=... flag to ld. > --- > configure.ac | 2 + > src/util/Makefile.sources | 2 + > src/util/build_id.c |

[Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

2017-02-14 Thread Matt Turner
Provides the ability to read the .note.gnu.build-id section of ELF binaries, which is inserted by the --build-id=... flag to ld. --- configure.ac | 2 + src/util/Makefile.sources | 2 + src/util/build_id.c | 109 ++ src/util/build_