On Thu, 2017-03-09 at 14:05 -0800, Jason Ekstrand wrote:
> Apart from avoiding some unneeded size cases, this shouldn't have any
> actual functional impact.
> ---
> src/compiler/nir/nir_constant_expressions.py | 51 +++---
> --
> 1 file changed, 27 insertions(+), 24 deletions(-
Quoting Jason Ekstrand (2017-03-09 14:19:33)
> On Thu, Mar 9, 2017 at 12:25 PM, Dylan Baker wrote:
>
>
>
> Quoting Jason Ekstrand (2017-03-09 10:23:56)
> > +def op_bit_sizes(op):
> > + sizes = set([8, 16, 32, 64])
> > + if not type_has_size(op.output_type):
> > +
Looks fine :
Reviewed-by: Lionel Landwerlin
On 09/03/17 22:05, Jason Ekstrand wrote:
Apart from avoiding some unneeded size cases, this shouldn't have any
actual functional impact.
---
src/compiler/nir/nir_constant_expressions.py | 51 +++-
1 file changed, 27 inserti
On Thu, Mar 9, 2017 at 12:25 PM, Dylan Baker wrote:
>
>
> Quoting Jason Ekstrand (2017-03-09 10:23:56)
> > +def op_bit_sizes(op):
> > +sizes = set([8, 16, 32, 64])
> > +if not type_has_size(op.output_type):
> > +sizes = sizes.intersection(set(type_sizes(op.output_type)))
> > +
Apart from avoiding some unneeded size cases, this shouldn't have any
actual functional impact.
---
src/compiler/nir/nir_constant_expressions.py | 51 +++-
1 file changed, 27 insertions(+), 24 deletions(-)
diff --git a/src/compiler/nir/nir_constant_expressions.py
b/src/co
Quoting Jason Ekstrand (2017-03-09 10:23:56)
> +def op_bit_sizes(op):
> +sizes = set([8, 16, 32, 64])
> +if not type_has_size(op.output_type):
> +sizes = sizes.intersection(set(type_sizes(op.output_type)))
> +for input_type in op.input_types:
> + if not type_has_size(inpu
Apart from avoiding some unneeded size cases, this shouldn't have any
actual functional impact.
---
src/compiler/nir/nir_constant_expressions.py | 51 +++-
1 file changed, 27 insertions(+), 24 deletions(-)
diff --git a/src/compiler/nir/nir_constant_expressions.py
b/src/co
