Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-03-01 Thread Andres Gomez
On Thu, 2018-03-01 at 09:25 +, Eric Engestrom wrote: [...] > > Oh, my apologies, I didn't think about that! > Can you add that paragraph in the commit message so it's clearer? > (I know there was already a mention of that, but I had not understood it the > first time around) > > > > > You

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-03-01 Thread Eric Engestrom
On February 28, 2018 8:30:14 PM UTC, Andres Gomez wrote: > On Wed, 2018-02-28 at 17:12 +, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:08:41 +, Eric Engestrom wrote: > > > On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > > > > On Wednesday, 2018-02-28 17:52:05 +0

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Andres Gomez
On Wed, 2018-02-28 at 17:12 +, Eric Engestrom wrote: > On Wednesday, 2018-02-28 17:08:41 +, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > > > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > > > 3 digits versions in LLVM only star

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Roland Scheidegger
Am 28.02.2018 um 18:18 schrieb Dylan Baker: > Quoting Eric Engestrom (2018-02-28 09:08:41) >> On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: >>> On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Dylan Baker
Quoting Eric Engestrom (2018-02-28 09:08:41) > On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > > > have installed 3.4 or below, meson will fail

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Eric Engestrom
On Wednesday, 2018-02-28 17:08:41 +, Eric Engestrom wrote: > On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > > > have installed 3.4 or belo

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Eric Engestrom
On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > > have installed 3.4 or below, meson will fail even when we may not make > > use of LLVM. > > > >

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Eric Engestrom
On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > have installed 3.4 or below, meson will fail even when we may not make > use of LLVM. > > Cc: Dylan Baker > Cc: Eric Engestrom > Signed-off-by: Andres Gomez > ---

[Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Andres Gomez
3 digits versions in LLVM only started from 3.4.1 on. Hence, if you have installed 3.4 or below, meson will fail even when we may not make use of LLVM. Cc: Dylan Baker Cc: Eric Engestrom Signed-off-by: Andres Gomez --- meson.build | 13 - 1 file changed, 12 insertions(+), 1 deletio