Re: [Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

2015-11-01 Thread Timothy Arceri
On Sun, 2015-11-01 at 08:03 +0200, Tapani Pälli wrote: > On 11/01/2015 01:20 AM, Timothy Arceri wrote: > > On Sat, 2015-10-31 at 06:52 +0200, Tapani Pälli wrote: > > > On 10/30/2015 05:57 PM, Ilia Mirkin wrote: > > > > On Fri, Oct 30, 2015 at 8:30 AM, Tapani Pälli > > > > wrote: > > > > > Since in

Re: [Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

2015-10-31 Thread Tapani Pälli
On 11/01/2015 01:20 AM, Timothy Arceri wrote: On Sat, 2015-10-31 at 06:52 +0200, Tapani Pälli wrote: On 10/30/2015 05:57 PM, Ilia Mirkin wrote: On Fri, Oct 30, 2015 at 8:30 AM, Tapani Pälli wrote: Since introduction of SSBO, UniformStorage contains not just uniforms but also buffer variables,

Re: [Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

2015-10-31 Thread Timothy Arceri
On Sat, 2015-10-31 at 06:52 +0200, Tapani Pälli wrote: > On 10/30/2015 05:57 PM, Ilia Mirkin wrote: > > On Fri, Oct 30, 2015 at 8:30 AM, Tapani Pälli > > wrote: > > > Since introduction of SSBO, UniformStorage contains not just uniforms > > > but also buffer variables, this needs to be taken in to

Re: [Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

2015-10-31 Thread Timothy Arceri
On Fri, 2015-10-30 at 11:57 -0400, Ilia Mirkin wrote: > On Fri, Oct 30, 2015 at 8:30 AM, Tapani Pälli > wrote: > > Since introduction of SSBO, UniformStorage contains not just uniforms > > but also buffer variables, this needs to be taken in to account when > > calculating active uniforms with GL_

Re: [Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

2015-10-30 Thread Tapani Pälli
On 10/30/2015 05:57 PM, Ilia Mirkin wrote: On Fri, Oct 30, 2015 at 8:30 AM, Tapani Pälli wrote: Since introduction of SSBO, UniformStorage contains not just uniforms but also buffer variables, this needs to be taken in to account when calculating active uniforms with GL_ACTIVE_UNIFORMS and GL_A

Re: [Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

2015-10-30 Thread Ilia Mirkin
On Fri, Oct 30, 2015 at 8:30 AM, Tapani Pälli wrote: > Since introduction of SSBO, UniformStorage contains not just uniforms > but also buffer variables, this needs to be taken in to account when > calculating active uniforms with GL_ACTIVE_UNIFORMS and > GL_ACTIVE_UNIFORM_MAX_LENGTH. > > No Pigli

Re: [Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

2015-10-30 Thread Eduardo Lima Mitev
On 10/30/2015 01:30 PM, Tapani Pälli wrote: > Since introduction of SSBO, UniformStorage contains not just uniforms > but also buffer variables, this needs to be taken in to account when > calculating active uniforms with GL_ACTIVE_UNIFORMS and > GL_ACTIVE_UNIFORM_MAX_LENGTH. > > No Piglit regress

[Mesa-dev] [PATCH 1/2] mesa: fix uniforms calculation in glGetProgramiv

2015-10-30 Thread Tapani Pälli
Since introduction of SSBO, UniformStorage contains not just uniforms but also buffer variables, this needs to be taken in to account when calculating active uniforms with GL_ACTIVE_UNIFORMS and GL_ACTIVE_UNIFORM_MAX_LENGTH. No Piglit regressions. Signed-off-by: Tapani Pälli --- src/mesa/main/s