Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

2015-11-18 Thread Kenneth Graunke
On Wednesday, November 18, 2015 06:25:45 PM Ian Romanick wrote: > On 11/18/2015 06:15 PM, Matt Turner wrote: > > On Wed, Nov 18, 2015 at 6:07 PM, Ian Romanick wrote: > >> On 11/18/2015 03:01 PM, Nanley Chery wrote: > >>> From: Nanley Chery > >>> > >>> Make it easier to determine where to add new

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

2015-11-18 Thread Ian Romanick
On 11/18/2015 06:15 PM, Matt Turner wrote: > On Wed, Nov 18, 2015 at 6:07 PM, Ian Romanick wrote: >> On 11/18/2015 03:01 PM, Nanley Chery wrote: >>> From: Nanley Chery >>> >>> Make it easier to determine where to add new extensions. >>> Performed with the vim sort command. >> >> Uh... no, please.

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

2015-11-18 Thread Matt Turner
On Wed, Nov 18, 2015 at 6:07 PM, Ian Romanick wrote: > On 11/18/2015 03:01 PM, Nanley Chery wrote: >> From: Nanley Chery >> >> Make it easier to determine where to add new extensions. >> Performed with the vim sort command. > > Uh... no, please. Extensions should be sorted in each group, but wha

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

2015-11-18 Thread Ian Romanick
On 11/18/2015 03:01 PM, Nanley Chery wrote: > From: Nanley Chery > > Make it easier to determine where to add new extensions. > Performed with the vim sort command. Uh... no, please. Extensions should be sorted in each group, but what is wrong with the old group ordering? ARB, KHR, OES, EXT, t

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

2015-11-18 Thread Nanley Chery
On Wed, Nov 18, 2015 at 3:47 PM, Matt Turner wrote: > > On Wed, Nov 18, 2015 at 3:01 PM, Nanley Chery wrote: > > From: Nanley Chery > > > > Make it easier to determine where to add new extensions. > > Performed with the vim sort command. > > Well, I think I'm obligated to review such a patch :)

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

2015-11-18 Thread Ilia Mirkin
On Wed, Nov 18, 2015 at 6:47 PM, Matt Turner wrote: > On Wed, Nov 18, 2015 at 3:01 PM, Nanley Chery wrote: >> From: Nanley Chery >> >> Make it easier to determine where to add new extensions. >> Performed with the vim sort command. > > Well, I think I'm obligated to review such a patch :) > >> S

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

2015-11-18 Thread Matt Turner
On Wed, Nov 18, 2015 at 3:01 PM, Nanley Chery wrote: > From: Nanley Chery > > Make it easier to determine where to add new extensions. > Performed with the vim sort command. Well, I think I'm obligated to review such a patch :) > Signed-off-by: Nanley Chery > --- > src/mesa/main/extensions_ta

[Mesa-dev] [PATCH 1/2] mesa/extensions: Sort the extension table alphabetically

2015-11-18 Thread Nanley Chery
From: Nanley Chery Make it easier to determine where to add new extensions. Performed with the vim sort command. Signed-off-by: Nanley Chery --- src/mesa/main/extensions_table.h | 173 +-- 1 file changed, 92 insertions(+), 81 deletions(-) diff --git a/src/m