Re: [Mesa-dev] [PATCH 1/2] i965: Massively simplify the intel_upload implementation.

2014-03-26 Thread Kenneth Graunke
On 03/26/2014 11:14 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> On 03/25/2014 11:27 AM, Eric Anholt wrote: >>> The implementation kept a page-sized area for uploading data, and >>> uploaded chunks from that to a 64kb-sized streamed buffer. This wasted >>> cache footprint (and extra sta

Re: [Mesa-dev] [PATCH 1/2] i965: Massively simplify the intel_upload implementation.

2014-03-26 Thread Eric Anholt
Kenneth Graunke writes: > On 03/25/2014 11:27 AM, Eric Anholt wrote: >> The implementation kept a page-sized area for uploading data, and >> uploaded chunks from that to a 64kb-sized streamed buffer. This wasted >> cache footprint (and extra state tracking to do so) when we want to just >> write

Re: [Mesa-dev] [PATCH 1/2] i965: Massively simplify the intel_upload implementation.

2014-03-25 Thread Kenneth Graunke
On 03/25/2014 11:27 AM, Eric Anholt wrote: > The implementation kept a page-sized area for uploading data, and > uploaded chunks from that to a 64kb-sized streamed buffer. This wasted > cache footprint (and extra state tracking to do so) when we want to just > write our data into the buffer immedi

[Mesa-dev] [PATCH 1/2] i965: Massively simplify the intel_upload implementation.

2014-03-25 Thread Eric Anholt
The implementation kept a page-sized area for uploading data, and uploaded chunks from that to a 64kb-sized streamed buffer. This wasted cache footprint (and extra state tracking to do so) when we want to just write our data into the buffer immediately. Instead, build it around an interface like