Re: [Mesa-dev] [PATCH 1/2] i965: Fix reference counting in new basevertex upload code.

2014-09-12 Thread Ian Romanick
On 09/12/2014 09:05 AM, Kenneth Graunke wrote: > On Friday, September 12, 2014 08:35:03 AM Ian Romanick wrote: >> On 09/10/2014 03:41 PM, Kenneth Graunke wrote: >>> In the non-indirect draw case, we call intel_upload_data to upload >>> gl_BaseVertex. It makes brw->draw.draw_params_bo point to the

Re: [Mesa-dev] [PATCH 1/2] i965: Fix reference counting in new basevertex upload code.

2014-09-12 Thread Kenneth Graunke
On Friday, September 12, 2014 08:35:03 AM Ian Romanick wrote: > On 09/10/2014 03:41 PM, Kenneth Graunke wrote: > > In the non-indirect draw case, we call intel_upload_data to upload > > gl_BaseVertex. It makes brw->draw.draw_params_bo point to the upload > > buffer, and increments the upload BO re

Re: [Mesa-dev] [PATCH 1/2] i965: Fix reference counting in new basevertex upload code.

2014-09-12 Thread Ian Romanick
On 09/10/2014 03:41 PM, Kenneth Graunke wrote: > In the non-indirect draw case, we call intel_upload_data to upload > gl_BaseVertex. It makes brw->draw.draw_params_bo point to the upload > buffer, and increments the upload BO reference count. > > So, we need to unreference it when making brw->dra

[Mesa-dev] [PATCH 1/2] i965: Fix reference counting in new basevertex upload code.

2014-09-10 Thread Kenneth Graunke
In the non-indirect draw case, we call intel_upload_data to upload gl_BaseVertex. It makes brw->draw.draw_params_bo point to the upload buffer, and increments the upload BO reference count. So, we need to unreference it when making brw->draw.draw_params_bo point at something else, or else we'll r