Re: [Mesa-dev] [PATCH 1/2] i965: Extract depctrl hazards

2014-11-21 Thread Matt Turner
On Fri, Nov 21, 2014 at 11:18 AM, Ben Widawsky wrote: > On Fri, Nov 21, 2014 at 11:04:18AM -0800, Matt Turner wrote: >> On Fri, Nov 21, 2014 at 10:50 AM, Ben Widawsky >> wrote: >> > +*/ + return !(inst->mlen || inst->predicate || inst->is_math()); >> >> The return value is a ! expression, a

Re: [Mesa-dev] [PATCH 1/2] i965: Extract depctrl hazards

2014-11-21 Thread Ben Widawsky
On Fri, Nov 21, 2014 at 11:04:18AM -0800, Matt Turner wrote: > On Fri, Nov 21, 2014 at 10:50 AM, Ben Widawsky > wrote: > > Move this to a separate function so that we can begin to add other little > > caveats without making too big a mess. > > > > NOTE: There is some desire to improve this functio

Re: [Mesa-dev] [PATCH 1/2] i965: Extract depctrl hazards

2014-11-21 Thread Matt Turner
On Fri, Nov 21, 2014 at 10:50 AM, Ben Widawsky wrote: > Move this to a separate function so that we can begin to add other little > caveats without making too big a mess. > > NOTE: There is some desire to improve this function eventually, but we need to > fix a bug first. > > Signed-off-by: Ben Wi

[Mesa-dev] [PATCH 1/2] i965: Extract depctrl hazards

2014-11-21 Thread Ben Widawsky
Move this to a separate function so that we can begin to add other little caveats without making too big a mess. NOTE: There is some desire to improve this function eventually, but we need to fix a bug first. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 42 ++