Re: [Mesa-dev] [PATCH 1/2] i965: Add accumulator flag support and MAC opcode to use it

2014-03-14 Thread Kenneth Graunke
On 03/10/2014 07:59 AM, Juha-Pekka Heikkila wrote: > This change MACH, ADDC and SUBB opcodes to use added accumulator > flag and add new opcode MAC which use accumulator flag. > > Signed-off-by: Juha-Pekka Heikkila I'm going to be a bit pedantic here (sorry!). Normally, commit messages are of t

Re: [Mesa-dev] [PATCH 1/2] i965: Add accumulator flag support and MAC opcode to use it

2014-03-10 Thread Matt Turner
I'd probably split this into two patches: i965/vec4: Add and use writes_accumulator flag. i965/vec4: Add and use MAC instruction. (or drop the /vec4 prefixes and implement it for both vec4 and fs backends! :) The first patch also needs to update the instruction scheduling code in brw_schedule_in

[Mesa-dev] [PATCH 1/2] i965: Add accumulator flag support and MAC opcode to use it

2014-03-10 Thread Juha-Pekka Heikkila
This change MACH, ADDC and SUBB opcodes to use added accumulator flag and add new opcode MAC which use accumulator flag. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/brw_eu.h | 1 + src/mesa/drivers/dri/i965/brw_vec4.cpp | 10 ++ src/mesa/driv