Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-16 Thread Kenneth Graunke
On Monday, March 16, 2015 03:16:32 PM Matt Turner wrote: > On Mon, Mar 16, 2015 at 2:44 PM, Kenneth Graunke > wrote: > > On Monday, March 16, 2015 07:54:45 AM Tapani Pälli wrote: > >> My first attempt to fix the bug 89569 was to add check in combine > >> constants but for some reason I did not ge

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-16 Thread Matt Turner
On Mon, Mar 16, 2015 at 2:44 PM, Kenneth Graunke wrote: > On Monday, March 16, 2015 07:54:45 AM Tapani Pälli wrote: >> My first attempt to fix the bug 89569 was to add check in combine >> constants but for some reason I did not get it to work. One reason is >> that inst->sources cannot be trusted

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-16 Thread Kenneth Graunke
On Monday, March 16, 2015 07:54:45 AM Tapani Pälli wrote: > My first attempt to fix the bug 89569 was to add check in combine > constants but for some reason I did not get it to work. One reason is > that inst->sources cannot be trusted I certainly hope we can trust it. If it's wrong, we need t

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-15 Thread Tapani Pälli
On 03/14/2015 02:46 AM, Kenneth Graunke wrote: On Friday, March 13, 2015 04:40:17 PM Matt Turner wrote: On Fri, Mar 13, 2015 at 4:16 PM, Kenneth Graunke wrote: Commit 36bc5f06dd22 began allowing immediates in MAD and LRP sources, in any position. One unforeseen consequence is that opt_algeb

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-13 Thread Kenneth Graunke
On Friday, March 13, 2015 04:40:17 PM Matt Turner wrote: > On Fri, Mar 13, 2015 at 4:16 PM, Kenneth Graunke > wrote: > > Commit 36bc5f06dd22 began allowing immediates in MAD and LRP sources, > > in any position. One unforeseen consequence is that opt_algebraic began > > creating ADD and MUL inst

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-13 Thread Matt Turner
On Fri, Mar 13, 2015 at 4:16 PM, Kenneth Graunke wrote: > Commit 36bc5f06dd22 began allowing immediates in MAD and LRP sources, > in any position. One unforeseen consequence is that opt_algebraic began > creating ADD and MUL instructions with src0 immediates. > > For example, > >mad(8) vgrf86

[Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-13 Thread Kenneth Graunke
Commit 36bc5f06dd22 began allowing immediates in MAD and LRP sources, in any position. One unforeseen consequence is that opt_algebraic began creating ADD and MUL instructions with src0 immediates. For example, mad(8) vgrf86:F, 1.00f, 1.00f, vgrf84:F would be optimized into: add(