Re: [Mesa-dev] [PATCH 1/2] i965/fs: Fix texelFetchOffset() on pre-Gen7.

2012-06-05 Thread Kenneth Graunke
On 06/05/2012 10:59 AM, Eric Anholt wrote: > On Mon, 4 Jun 2012 14:15:10 -0700, Kenneth Graunke > wrote: >> Commit f41ecade7b458c02d504158b522acb2231585040 fixed texelFetchOffset() >> on Ivybridge, but didn't update the Ironlake/Sandybridge code. >> >> +15 piglits on Sandybridge. >> >> NOTE: Thi

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Fix texelFetchOffset() on pre-Gen7.

2012-06-05 Thread Eric Anholt
On Mon, 4 Jun 2012 14:15:10 -0700, Kenneth Graunke wrote: > Commit f41ecade7b458c02d504158b522acb2231585040 fixed texelFetchOffset() > on Ivybridge, but didn't update the Ironlake/Sandybridge code. > > +15 piglits on Sandybridge. > > NOTE: This and f41ecade7b458 are both candidates for stable

[Mesa-dev] [PATCH 1/2] i965/fs: Fix texelFetchOffset() on pre-Gen7.

2012-06-04 Thread Kenneth Graunke
Commit f41ecade7b458c02d504158b522acb2231585040 fixed texelFetchOffset() on Ivybridge, but didn't update the Ironlake/Sandybridge code. +15 piglits on Sandybridge. NOTE: This and f41ecade7b458 are both candidates for stable branches. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 1/2] i965/fs: Fix texelFetchOffset()

2012-04-17 Thread Eric Anholt
It appears that when using 'ld' with the offset bits, address bounds checking happens before the offset is applied, so parts of the drawing in piglit texelFetchOffset() with a negative texcoord go black. --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 27 -- 1 file cha