Re: [Mesa-dev] [PATCH 1/2] i965/brw: Emit state for hiz and separate stencil buffers

2011-06-05 Thread Chad Versace
On Sun, 05 Jun 2011 01:37:27 -0700, Kenneth Graunke wrote: > On 06/04/2011 04:29 PM, Chad Versace wrote: > > On 06/03/2011 03:33 PM, Kenneth Graunke wrote: > >> Do we need to emit 3DSTATE_STENCIL_BUFFER with all 0's in the stencil_irb > >> == NULL case? Ditto for HiZ I guess. Just being a > >>

Re: [Mesa-dev] [PATCH 1/2] i965/brw: Emit state for hiz and separate stencil buffers

2011-06-05 Thread Kenneth Graunke
On 06/04/2011 04:29 PM, Chad Versace wrote: On 06/03/2011 03:33 PM, Kenneth Graunke wrote: Do we need to emit 3DSTATE_STENCIL_BUFFER with all 0's in the stencil_irb == NULL case? Ditto for HiZ I guess. Just being a bit paranoid. The test results for these paranoiac cases pass, so paranoia i

Re: [Mesa-dev] [PATCH 1/2] i965/brw: Emit state for hiz and separate stencil buffers

2011-06-04 Thread Chad Versace
On 06/03/2011 03:33 PM, Kenneth Graunke wrote: > On 06/03/2011 12:47 PM, Chad Versace wrote: >> When emitting 3DSTATE_DEPTH_BUFFER, also emit 3DSTATE_HIER_DEPTH_BUFFER if >> there is a hiz buffer. Ditto for 3DSTATE_STENCIL_BUFFER and a separate >> stencil buffer. >> >> Signed-off-by: Chad Versace >

Re: [Mesa-dev] [PATCH 1/2] i965/brw: Emit state for hiz and separate stencil buffers

2011-06-03 Thread Eric Anholt
On Fri, 3 Jun 2011 12:47:58 -0700, Chad Versace wrote: > When emitting 3DSTATE_DEPTH_BUFFER, also emit 3DSTATE_HIER_DEPTH_BUFFER if > there is a hiz buffer. Ditto for 3DSTATE_STENCIL_BUFFER and a separate > stencil buffer. > > Signed-off-by: Chad Versace both: Reviewed-by: Eric Anholt I've b

Re: [Mesa-dev] [PATCH 1/2] i965/brw: Emit state for hiz and separate stencil buffers

2011-06-03 Thread Kenneth Graunke
On 06/03/2011 12:47 PM, Chad Versace wrote: When emitting 3DSTATE_DEPTH_BUFFER, also emit 3DSTATE_HIER_DEPTH_BUFFER if there is a hiz buffer. Ditto for 3DSTATE_STENCIL_BUFFER and a separate stencil buffer. Signed-off-by: Chad Versace Overall, looks good...a few comments inline. --- src/mes

[Mesa-dev] [PATCH 1/2] i965/brw: Emit state for hiz and separate stencil buffers

2011-06-03 Thread Chad Versace
When emitting 3DSTATE_DEPTH_BUFFER, also emit 3DSTATE_HIER_DEPTH_BUFFER if there is a hiz buffer. Ditto for 3DSTATE_STENCIL_BUFFER and a separate stencil buffer. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_misc_state.c | 114 -- src/mesa/drivers/dri/i