Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-12 Thread Ilia Mirkin
On Wed, Aug 12, 2015 at 1:58 PM, Matt Turner wrote: > On Tue, Aug 11, 2015 at 6:51 PM, Ilia Mirkin wrote: >> --- >> src/glsl/builtin_functions.cpp | 32 >> +- >> src/glsl/glcpp/glcpp-parse.y | 3 +++ >> src/glsl/glsl_parser_extras.cpp

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-12 Thread Matt Turner
On Tue, Aug 11, 2015 at 6:51 PM, Ilia Mirkin wrote: > --- > src/glsl/builtin_functions.cpp | 32 > +- > src/glsl/glcpp/glcpp-parse.y | 3 +++ > src/glsl/glsl_parser_extras.cpp| 1 + > src/glsl/glsl_parser_extras.h |

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-12 Thread Tapani Pälli
On 08/12/2015 03:00 PM, Ilia Mirkin wrote: On Wed, Aug 12, 2015 at 2:34 AM, Tapani Pälli wrote: Hi Ilia; Some comments below; On 08/12/2015 04:51 AM, Ilia Mirkin wrote: --- src/glsl/builtin_functions.cpp | 32 +- src/glsl/glcpp/glcpp-parse.y

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-12 Thread Ilia Mirkin
On Wed, Aug 12, 2015 at 2:34 AM, Tapani Pälli wrote: > Hi Ilia; > > Some comments below; > > > On 08/12/2015 04:51 AM, Ilia Mirkin wrote: >> >> --- >> src/glsl/builtin_functions.cpp | 32 >> +- >> src/glsl/glcpp/glcpp-parse.y | 3 +++ >> s

Re: [Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-11 Thread Tapani Pälli
Hi Ilia; Some comments below; On 08/12/2015 04:51 AM, Ilia Mirkin wrote: --- src/glsl/builtin_functions.cpp | 32 +- src/glsl/glcpp/glcpp-parse.y | 3 +++ src/glsl/glsl_parser_extras.cpp| 1 + src/glsl/glsl_parser_extras.h

[Mesa-dev] [PATCH 1/2] glsl: add support for textureSamples function

2015-08-11 Thread Ilia Mirkin
--- src/glsl/builtin_functions.cpp | 32 +- src/glsl/glcpp/glcpp-parse.y | 3 +++ src/glsl/glsl_parser_extras.cpp| 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/glsl/ir.cpp| 5 +++-- src