Re: [Mesa-dev] [PATCH 1/2] glsl: Fix undefined shifts.

2016-01-02 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-12-30 12:26:25, Matt Turner wrote: > Shifting into the sign bit if undefined, as is shifting by 32. > --- > src/glsl/ir_constant_expression.cpp | 10 +- > src/glsl/nir/nir_opcodes.py | 6 +++--- > 2 files changed, 8 insertions(+), 8 deletions(-

[Mesa-dev] [PATCH 1/2] glsl: Fix undefined shifts.

2015-12-30 Thread Matt Turner
Shifting into the sign bit if undefined, as is shifting by 32. --- src/glsl/ir_constant_expression.cpp | 10 +- src/glsl/nir/nir_opcodes.py | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expres