Re: [Mesa-dev] [PATCH 1/2] glsl: Fix redeclaration rules for gl_FragCoord.

2014-05-01 Thread Chris Forbes
OK, sounds good to me. On Fri, May 2, 2014 at 5:55 AM, Anuj Phogat wrote: > On Thu, Apr 17, 2014 at 1:05 AM, Chris Forbes wrote: >> Correct, this doesn't try to tackle the link-time cases at all. >> >> After sending these out, Anuj told me that he had similar patches >> pending review. Unfortuna

Re: [Mesa-dev] [PATCH 1/2] glsl: Fix redeclaration rules for gl_FragCoord.

2014-05-01 Thread Anuj Phogat
On Thu, Apr 17, 2014 at 1:05 AM, Chris Forbes wrote: > Correct, this doesn't try to tackle the link-time cases at all. > > After sending these out, Anuj told me that he had similar patches > pending review. Unfortunate to duplicate effort, but it's what I get > for doing a bunch of random bug-stom

Re: [Mesa-dev] [PATCH 1/2] glsl: Fix redeclaration rules for gl_FragCoord.

2014-04-17 Thread Chris Forbes
Correct, this doesn't try to tackle the link-time cases at all. After sending these out, Anuj told me that he had similar patches pending review. Unfortunate to duplicate effort, but it's what I get for doing a bunch of random bug-stomping, I guess :) Hopefully we can pick the best ideas from bot

Re: [Mesa-dev] [PATCH 1/2] glsl: Fix redeclaration rules for gl_FragCoord.

2014-04-16 Thread Kenneth Graunke
On 04/12/2014 10:30 PM, Chris Forbes wrote: > The ARB_fragment_coord_conventions spec, section 4.3.x (Input Layout > Qualifiers) says: > > "All redeclarations of gl_FragCoord in all fragment shaders in a > single program must have the same set of qualifiers. Within any > shader, the first re

[Mesa-dev] [PATCH 1/2] glsl: Fix redeclaration rules for gl_FragCoord.

2014-04-12 Thread Chris Forbes
The ARB_fragment_coord_conventions spec, section 4.3.x (Input Layout Qualifiers) says: "All redeclarations of gl_FragCoord in all fragment shaders in a single program must have the same set of qualifiers. Within any shader, the first redeclarations of gl_FragCoord must appear before any us