Re: [Mesa-dev] [PATCH 1/2] glsl: Add define for ARB_shader_precision

2015-02-01 Thread Chris Forbes
Glenn, Fixed in the version of this patch which landed (d36fa601913 on master). - Chris On Mon, Feb 2, 2015 at 2:08 PM, Glenn Kennard wrote: > On Wed, 31 Dec 2014 21:43:51 +0100, Micah Fedke > wrote: > >> --- >> src/glsl/glcpp/glcpp-parse.y| 3 +++ >> src/glsl/glsl_parser_extras.cpp | 1 +

Re: [Mesa-dev] [PATCH 1/2] glsl: Add define for ARB_shader_precision

2015-02-01 Thread Glenn Kennard
On Wed, 31 Dec 2014 21:43:51 +0100, Micah Fedke wrote: --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 5 files changed, 8 insertions(+) d

Re: [Mesa-dev] [PATCH 1/2] glsl: Add define for ARB_shader_precision

2015-01-01 Thread Ian Romanick
On 12/31/2014 12:43 PM, Micah Fedke wrote: This patch does a little more than just add the define. If you change the commit message to something like "mesa: Add ARB_shader_precision infrastructure", you get Reviewed-by: Ian Romanick > --- > src/glsl/glcpp/glcpp-parse.y| 3 +++ > src/glsl/

[Mesa-dev] [PATCH 1/2] glsl: Add define for ARB_shader_precision

2014-12-31 Thread Micah Fedke
--- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 5 files changed, 8 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glc