Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-27 Thread Carl Worth
Ian Romanick writes: >> (The first "is" should be "if"). > > That's in patch #2. :) Yeah, that's what I get for reviewing patches in the order they arrive on the list... :-) -Carl pgpWgJ3mrTEsx.pgp Description: PGP signature ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-27 Thread Ian Romanick
On 01/27/2014 04:18 PM, Matt Turner wrote: > On Mon, Jan 27, 2014 at 3:14 PM, Ian Romanick wrote: >> On 01/26/2014 07:14 PM, Matt Turner wrote: >>> The check was in the wrong place, such that if a shader incorrectly put >>> a preprocessor token before the #version declaration, the version would >>

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-27 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/27/2014 03:34 PM, Carl Worth wrote: > Matt Turner writes: >> The check was in the wrong place, such that if a shader >> incorrectly put a preprocessor token before the #version >> declaration, the version would be resolved twice, leading to a >>

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-27 Thread Matt Turner
On Mon, Jan 27, 2014 at 3:14 PM, Ian Romanick wrote: > On 01/26/2014 07:14 PM, Matt Turner wrote: >> The check was in the wrong place, such that if a shader incorrectly put >> a preprocessor token before the #version declaration, the version would >> be resolved twice, leading to a segmentation fa

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-27 Thread Ian Romanick
On 01/26/2014 07:14 PM, Matt Turner wrote: > The check was in the wrong place, such that if a shader incorrectly put > a preprocessor token before the #version declaration, the version would > be resolved twice, leading to a segmentation fault when attempting to > redefine the __VERSION__ macro. >

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-27 Thread Carl Worth
Matt Turner writes: > The check was in the wrong place, such that if a shader incorrectly put > a preprocessor token before the #version declaration, the version would > be resolved twice, leading to a segmentation fault when attempting to > redefine the __VERSION__ macro. This fix looks good. An

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-26 Thread Jordan Justen
On Sun, Jan 26, 2014 at 8:23 PM, Matt Turner wrote: > On Sun, Jan 26, 2014 at 8:15 PM, Jordan Justen wrote: >> On Sun, Jan 26, 2014 at 6:14 PM, Matt Turner wrote: >>> The check was in the wrong place, such that if a shader incorrectly put >>> a preprocessor token before the #version declaration,

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-26 Thread Matt Turner
On Sun, Jan 26, 2014 at 8:15 PM, Jordan Justen wrote: > On Sun, Jan 26, 2014 at 6:14 PM, Matt Turner wrote: >> The check was in the wrong place, such that if a shader incorrectly put >> a preprocessor token before the #version declaration, the version would >> be resolved twice, leading to a segm

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-26 Thread Jordan Justen
On Sun, Jan 26, 2014 at 6:14 PM, Matt Turner wrote: > The check was in the wrong place, such that if a shader incorrectly put > a preprocessor token before the #version declaration, the version would > be resolved twice, leading to a segmentation fault when attempting to > redefine the __VERSION__

[Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-26 Thread Matt Turner
The check was in the wrong place, such that if a shader incorrectly put a preprocessor token before the #version declaration, the version would be resolved twice, leading to a segmentation fault when attempting to redefine the __VERSION__ macro. #define GL_ARB_sample_shading #version 130 void m