Re: [Mesa-dev] [PATCH 1/2] gbm/dri2: propagate errors when creating a DMA-BUF fd

2016-09-22 Thread Emil Velikov
Hi Nicholas, On 8 September 2016 at 20:55, Nicholas Bishop wrote: > Changed dri2_query_image to check the return value of > resource_get_handle and return GL_FALSE if an error occurs. Similarly > changed gbm_dri_bo_get_fd to check the return value of queryImage and > return -1 (an invalid file de

Re: [Mesa-dev] [PATCH 1/2] gbm/dri2: propagate errors when creating a DMA-BUF fd

2016-09-22 Thread Nicholas Bishop
Bump, could someone push this? Thanks, -Nicholas On Wed, Sep 14, 2016 at 1:06 PM, Nicholas Bishop wrote: > Thanks for review. Could someone with commit access push this for me? > > On Wed, Sep 14, 2016 at 8:48 AM, Eric Engestrom > wrote: >> On Thu, Sep 08, 2016 at 03:55:02PM -0400, Nicholas Bis

Re: [Mesa-dev] [PATCH 1/2] gbm/dri2: propagate errors when creating a DMA-BUF fd

2016-09-14 Thread Nicholas Bishop
Thanks for review. Could someone with commit access push this for me? On Wed, Sep 14, 2016 at 8:48 AM, Eric Engestrom wrote: > On Thu, Sep 08, 2016 at 03:55:02PM -0400, Nicholas Bishop wrote: >> Changed dri2_query_image to check the return value of >> resource_get_handle and return GL_FALSE if an

Re: [Mesa-dev] [PATCH 1/2] gbm/dri2: propagate errors when creating a DMA-BUF fd

2016-09-14 Thread Eric Engestrom
On Thu, Sep 08, 2016 at 03:55:02PM -0400, Nicholas Bishop wrote: > Changed dri2_query_image to check the return value of > resource_get_handle and return GL_FALSE if an error occurs. Similarly > changed gbm_dri_bo_get_fd to check the return value of queryImage and > return -1 (an invalid file descr

[Mesa-dev] [PATCH 1/2] gbm/dri2: propagate errors when creating a DMA-BUF fd

2016-09-08 Thread Nicholas Bishop
Changed dri2_query_image to check the return value of resource_get_handle and return GL_FALSE if an error occurs. Similarly changed gbm_dri_bo_get_fd to check the return value of queryImage and return -1 (an invalid file descriptor) if an error occurs. Updated the comment for gbm_bo_get_fd to say