Re: [Mesa-dev] [PATCH 1/2] draw: simplify (and correct) aaline fallback (v2)

2018-03-07 Thread Roland Scheidegger
Am 07.03.2018 um 11:34 schrieb Jose Fonseca: > On 06/03/18 20:52, Brian Paul wrote: >> Looks good.  That certainly does simplify things.  Two minor >> suggestions below. >> >> In any case, for both, Reviewed-by: Brian Paul > > Looks great cleanup to me too.  Just minor issues inline. Both are >

Re: [Mesa-dev] [PATCH 1/2] draw: simplify (and correct) aaline fallback (v2)

2018-03-07 Thread Jose Fonseca
On 06/03/18 20:52, Brian Paul wrote: Looks good.  That certainly does simplify things.  Two minor suggestions below. In any case, for both, Reviewed-by: Brian Paul Looks great cleanup to me too.  Just minor issues inline. Both are Reviewed-by: Jose Fonseca On 03/06/2018 01:34 PM, srol...

Re: [Mesa-dev] [PATCH 1/2] draw: simplify (and correct) aaline fallback (v2)

2018-03-06 Thread Roland Scheidegger
Am 06.03.2018 um 21:52 schrieb Brian Paul: > Looks good.  That certainly does simplify things.  Two minor suggestions > below. > > In any case, for both, Reviewed-by: Brian Paul > > On 03/06/2018 01:34 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The motivation actually was t

Re: [Mesa-dev] [PATCH 1/2] draw: simplify (and correct) aaline fallback (v2)

2018-03-06 Thread Brian Paul
Looks good. That certainly does simplify things. Two minor suggestions below. In any case, for both, Reviewed-by: Brian Paul On 03/06/2018 01:34 PM, srol...@vmware.com wrote: From: Roland Scheidegger The motivation actually was to get rid of the additional tex instruction, since that requ

[Mesa-dev] [PATCH 1/2] draw: simplify (and correct) aaline fallback (v2)

2018-03-06 Thread sroland
From: Roland Scheidegger The motivation actually was to get rid of the additional tex instruction, since that requires the draw fallback code to intercept all sampler / view calls (even if the fallback is never hit). Basically, the idea is to use coverage of the pixel to calculate the alpha value