Re: [Mesa-dev] [PATCH 1/2] clover: Implement image attribute getters

2015-06-10 Thread Francisco Jerez
Zoltán Gilián writes: >> Whether you need to pass the image >> dimensions and data type to the kernel as explicit parameters or not >> (e.g. because your hardware already supports some sort of image metadata >> query opcode) is driver-specific, so it would probably be a better idea >> to append t

Re: [Mesa-dev] [PATCH 1/2] clover: Implement image attribute getters

2015-06-10 Thread Zoltán Gilián
> Whether you need to pass the image > dimensions and data type to the kernel as explicit parameters or not > (e.g. because your hardware already supports some sort of image metadata > query opcode) is driver-specific, so it would probably be a better idea > to append these parameters at the end of

Re: [Mesa-dev] [PATCH 1/2] clover: Implement image attribute getters

2015-06-09 Thread Zoltán Gilián
Ok, thanks for the feedback. On Mon, Jun 8, 2015 at 2:18 PM, Francisco Jerez wrote: > Zoltan Gilian writes: > > > Image attributes are passed to the kernel as hidden parameters after the > > image attribute itself. An llvm pass replaces the getter builtins to > > the appropriate parameters. > >

Re: [Mesa-dev] [PATCH 1/2] clover: Implement image attribute getters

2015-06-08 Thread Francisco Jerez
Zoltan Gilian writes: > Image attributes are passed to the kernel as hidden parameters after the > image attribute itself. An llvm pass replaces the getter builtins to > the appropriate parameters. > --- > src/gallium/state_trackers/clover/core/kernel.cpp | 13 ++ > src/gallium/state_trackers/

[Mesa-dev] [PATCH 1/2] clover: Implement image attribute getters

2015-06-08 Thread Zoltan Gilian
Image attributes are passed to the kernel as hidden parameters after the image attribute itself. An llvm pass replaces the getter builtins to the appropriate parameters. --- src/gallium/state_trackers/clover/core/kernel.cpp | 13 ++ src/gallium/state_trackers/clover/core/memory.cpp | 2 +- ..