Re: [Mesa-dev] [PATCH 1/2] R600: handle loops to self in the structurizer v2

2013-01-23 Thread Tom Stellard
On Mon, Jan 21, 2013 at 10:28:56PM +0100, Christian König wrote: > v2: don't mess up other loops > Hi Christian, This patch regresses the glsl1-do-loop test, this test worked fine with v1 of the patch, but the structurizer creates an infinite loop with v2. See attached LLVM IR. -Tom > Signed

Re: [Mesa-dev] [PATCH 1/2] R600: handle loops to self in the structurizer v2

2013-01-22 Thread Tom Stellard
On Tue, Jan 22, 2013 at 09:33:46AM -0600, Aaron Watry wrote: > > Am 22.01.2013 13:08, schrieb Michel Dänzer: > >> On Mon, 2013-01-21 at 22:28 +0100, Christian König wrote: > >>> v2: don't mess up other loops > >>> > >>> Signed-off-by: Christian König > Series is > >> > Tested-by: Michel Dänze

Re: [Mesa-dev] [PATCH 1/2] R600: handle loops to self in the structurizer v2

2013-01-22 Thread Aaron Watry
> Am 22.01.2013 13:08, schrieb Michel Dänzer: >> On Mon, 2013-01-21 at 22:28 +0100, Christian König wrote: >>> v2: don't mess up other loops >>> >>> Signed-off-by: Christian König > Series is >> > Tested-by: Michel Dänzer > > No piglit >> > regressions with radeonsi. :) >> > >> P.S. A coup

Re: [Mesa-dev] [PATCH 1/2] R600: handle loops to self in the structurizer v2

2013-01-22 Thread Christian König
Am 22.01.2013 13:08, schrieb Michel Dänzer: On Mon, 2013-01-21 at 22:28 +0100, Christian König wrote: v2: don't mess up other loops Signed-off-by: Christian König Series is Tested-by: Michel Dänzer No piglit regressions with radeonsi. :) P.S. A couple of piglit tests still crash in contr

Re: [Mesa-dev] [PATCH 1/2] R600: handle loops to self in the structurizer v2

2013-01-22 Thread Michel Dänzer
On Mon, 2013-01-21 at 22:28 +0100, Christian König wrote: > v2: don't mess up other loops > > Signed-off-by: Christian König Series is Tested-by: Michel Dänzer No piglit regressions with radeonsi. :) P.S. A couple of piglit tests still crash in control flow related code though, e.g. glean/

[Mesa-dev] [PATCH 1/2] R600: handle loops to self in the structurizer v2

2013-01-21 Thread Christian König
v2: don't mess up other loops Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG.cpp b/lib/Target/R600/AMDGPUStructurizeCFG.cpp index 22338b5..5be40de