Re: [Mesa-dev] [PATCH 1/1] radeonsi: Reorder checks in si_check_render_feedback

2018-04-05 Thread Jan Vesely
On Thu, 2018-04-05 at 16:56 -0400, Marek Olšák wrote: > Even though I've already fixed the crash in master, I'd like to have this > patch in master too. I think that's a different crash. I can still reproduce on c7dd59b06d93e6820189e2d1e087c0811707ee07: Thread 1 "test-short" received signal SIGSEG

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Reorder checks in si_check_render_feedback

2018-04-05 Thread Marek Olšák
Even though I've already fixed the crash in master, I'd like to have this patch in master too. Reviewed-by: Marek Olšák Marek On Thu, Apr 5, 2018 at 4:49 PM, Jan Vesely wrote: > si_get_total_colormask accesses NULL pointer on compute shaders > Fixes crashes on clover > Fixes: 0669dca9c0026184

[Mesa-dev] [PATCH 1/1] radeonsi: Reorder checks in si_check_render_feedback

2018-04-05 Thread Jan Vesely
si_get_total_colormask accesses NULL pointer on compute shaders Fixes crashes on clover Fixes: 0669dca9c00261849cee14d69fdea0a5e323c7f7 ("radeonsi: skip DCC render feedback checking if color writes are disabled") CC: Marek Olšák Signed-off-by: Jan Vesely --- src/gallium/drivers/radeonsi/si_blit