Re: [Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2015-01-14 Thread Connor Abbott
Together with the patches to lower all wildcard copies, Reviewed-by: Connor Abbott On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand wrote: > --- > src/glsl/Makefile.sources | 1 + > src/glsl/nir/nir.h | 2 + > src/glsl/nir/nir_lower_locals_to_regs.c | 313

Re: [Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2015-01-14 Thread Jason Ekstrand
On Wed, Jan 14, 2015 at 1:10 PM, Connor Abbott wrote: > On Fri, Jan 9, 2015 at 8:27 PM, Jason Ekstrand > wrote: > > > > > > On Fri, Jan 9, 2015 at 4:38 PM, Connor Abbott > wrote: > >> > >> + case nir_intrinsic_copy_var: > >> + unreachable("There should be no copies whatso

Re: [Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2015-01-14 Thread Connor Abbott
On Fri, Jan 9, 2015 at 8:27 PM, Jason Ekstrand wrote: > > > On Fri, Jan 9, 2015 at 4:38 PM, Connor Abbott wrote: >> >> + case nir_intrinsic_copy_var: >> + unreachable("There should be no copies whatsoever at this >> point"); >> + break; >> >>> >> >>> >> >>

Re: [Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2015-01-09 Thread Jason Ekstrand
On Fri, Jan 9, 2015 at 4:38 PM, Connor Abbott wrote: > + case nir_intrinsic_copy_var: > + unreachable("There should be no copies whatsoever at this > point"); > + break; > >>> > >>> > >>> Are you sure about this? My impression is that lower_variables will

Re: [Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2015-01-09 Thread Connor Abbott
+ case nir_intrinsic_copy_var: + unreachable("There should be no copies whatsoever at this point"); + break; >>> >>> >>> Are you sure about this? My impression is that lower_variables will lower >>> copies involving things that aren't indirectly referenced,

Re: [Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2015-01-09 Thread Jason Ekstrand
On Tue, Jan 6, 2015 at 5:05 PM, Jason Ekstrand wrote: > > > On Sun, Jan 4, 2015 at 7:52 PM, Connor Abbott wrote: > >> >> >> On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand >> wrote: >> >>> --- >>> src/glsl/Makefile.sources | 1 + >>> src/glsl/nir/nir.h |

Re: [Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2015-01-06 Thread Jason Ekstrand
On Sun, Jan 4, 2015 at 7:52 PM, Connor Abbott wrote: > > > On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand > wrote: > >> --- >> src/glsl/Makefile.sources | 1 + >> src/glsl/nir/nir.h | 2 + >> src/glsl/nir/nir_lower_locals_to_regs.c | 313 >> ++

Re: [Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2015-01-04 Thread Connor Abbott
Oh, and I forgot... can we rename this to lower_local_to_regs_scalar or at least add a note that this won't work for vec4 backends yet due to the different indexing? On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand wrote: > --- > src/glsl/Makefile.sources | 1 + > src/glsl/nir/n

Re: [Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2015-01-04 Thread Connor Abbott
On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand wrote: > --- > src/glsl/Makefile.sources | 1 + > src/glsl/nir/nir.h | 2 + > src/glsl/nir/nir_lower_locals_to_regs.c | 313 > > 3 files changed, 316 insertions(+) > create mo

[Mesa-dev] [PATCH 092/133] nir: Add a pass to lower local variables to registers

2014-12-15 Thread Jason Ekstrand
--- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.h | 2 + src/glsl/nir/nir_lower_locals_to_regs.c | 313 3 files changed, 316 insertions(+) create mode 100644 src/glsl/nir/nir_lower_locals_to_regs.c diff --git a/src/gls