Re: [Mesa-dev] [PATCH 09/36] i965/blorp: Make sample count asserts a bit more lazy

2016-07-01 Thread Jason Ekstrand
On Jun 30, 2016 10:14 PM, "Pohjolainen, Topi" wrote: > > On Thu, Jun 30, 2016 at 06:57:39AM -0700, Jason Ekstrand wrote: > >On Jun 29, 2016 11:07 PM, "Pohjolainen, Topi" > ><[1]topi.pohjolai...@intel.com> wrote: > >> > >> On Wed, Jun 29, 2016 at 05:37:28PM -0700, Jason Ekstrand wro

Re: [Mesa-dev] [PATCH 09/36] i965/blorp: Make sample count asserts a bit more lazy

2016-06-30 Thread Pohjolainen, Topi
On Thu, Jun 30, 2016 at 06:57:39AM -0700, Jason Ekstrand wrote: >On Jun 29, 2016 11:07 PM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@intel.com> wrote: >> >> On Wed, Jun 29, 2016 at 05:37:28PM -0700, Jason Ekstrand wrote: >> > --- >> > src/mesa/drivers/dri/i965/brw_blorp_bli

Re: [Mesa-dev] [PATCH 09/36] i965/blorp: Make sample count asserts a bit more lazy

2016-06-30 Thread Jason Ekstrand
On Jun 29, 2016 11:07 PM, "Pohjolainen, Topi" wrote: > > On Wed, Jun 29, 2016 at 05:37:28PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Could you add some rational here? In the next

Re: [Mesa-dev] [PATCH 09/36] i965/blorp: Make sample count asserts a bit more lazy

2016-06-29 Thread Pohjolainen, Topi
On Wed, Jun 29, 2016 at 05:37:28PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Could you add some rational here? In the next patch you still use MAX2(mt->num_samples, 1) and it looks that it a

[Mesa-dev] [PATCH 09/36] i965/blorp: Make sample count asserts a bit more lazy

2016-06-29 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index 1e15bd5..257db06 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp_blit.