Re: [Mesa-dev] [PATCH 09/15] i965/fs: New peephole optimization to generate SEL.

2013-10-30 Thread Paul Berry
On 30 October 2013 10:23, Paul Berry wrote: > On 30 October 2013 10:10, Matt Turner wrote: > >> On Wed, Oct 30, 2013 at 9:30 AM, Paul Berry >> wrote: >> > On 28 October 2013 11:31, Matt Turner wrote: >> >> >> >> fs_visitor::try_replace_with_sel optimizes only if statements whose >> >> "then" a

Re: [Mesa-dev] [PATCH 09/15] i965/fs: New peephole optimization to generate SEL.

2013-10-30 Thread Paul Berry
On 30 October 2013 10:10, Matt Turner wrote: > On Wed, Oct 30, 2013 at 9:30 AM, Paul Berry > wrote: > > On 28 October 2013 11:31, Matt Turner wrote: > >> > >> fs_visitor::try_replace_with_sel optimizes only if statements whose > >> "then" and "else" bodies contain a single MOV instruction. It a

Re: [Mesa-dev] [PATCH 09/15] i965/fs: New peephole optimization to generate SEL.

2013-10-30 Thread Matt Turner
On Wed, Oct 30, 2013 at 10:06 AM, Paul Berry wrote: > On 28 October 2013 11:31, Matt Turner wrote: >> >> fs_visitor::try_replace_with_sel optimizes only if statements whose >> "then" and "else" bodies contain a single MOV instruction. It also did >> could not handle constant arguments, since they

Re: [Mesa-dev] [PATCH 09/15] i965/fs: New peephole optimization to generate SEL.

2013-10-30 Thread Matt Turner
On Wed, Oct 30, 2013 at 9:30 AM, Paul Berry wrote: > On 28 October 2013 11:31, Matt Turner wrote: >> >> fs_visitor::try_replace_with_sel optimizes only if statements whose >> "then" and "else" bodies contain a single MOV instruction. It also did >> could not handle constant arguments, since they

Re: [Mesa-dev] [PATCH 09/15] i965/fs: New peephole optimization to generate SEL.

2013-10-30 Thread Paul Berry
On 28 October 2013 11:31, Matt Turner wrote: > fs_visitor::try_replace_with_sel optimizes only if statements whose > "then" and "else" bodies contain a single MOV instruction. It also did > could not handle constant arguments, since they cause an extra MOV > immediate to be generated (since we ha

Re: [Mesa-dev] [PATCH 09/15] i965/fs: New peephole optimization to generate SEL.

2013-10-30 Thread Paul Berry
On 28 October 2013 11:31, Matt Turner wrote: > fs_visitor::try_replace_with_sel optimizes only if statements whose > "then" and "else" bodies contain a single MOV instruction. It also did > could not handle constant arguments, since they cause an extra MOV > s/did could not/could not/ > immedi

Re: [Mesa-dev] [PATCH 09/15] i965/fs: New peephole optimization to generate SEL.

2013-10-29 Thread Matt Turner
On Tue, Oct 29, 2013 at 4:57 AM, Pohjolainen, Topi wrote: > On Mon, Oct 28, 2013 at 11:31:33AM -0700, Matt Turner wrote: >> fs_visitor::try_replace_with_sel optimizes only if statements whose >> "then" and "else" bodies contain a single MOV instruction. It also did >> could not handle constant arg

Re: [Mesa-dev] [PATCH 09/15] i965/fs: New peephole optimization to generate SEL.

2013-10-29 Thread Pohjolainen, Topi
On Mon, Oct 28, 2013 at 11:31:33AM -0700, Matt Turner wrote: > fs_visitor::try_replace_with_sel optimizes only if statements whose > "then" and "else" bodies contain a single MOV instruction. It also did > could not handle constant arguments, since they cause an extra MOV > immediate to be generate

[Mesa-dev] [PATCH 09/15] i965/fs: New peephole optimization to generate SEL.

2013-10-28 Thread Matt Turner
fs_visitor::try_replace_with_sel optimizes only if statements whose "then" and "else" bodies contain a single MOV instruction. It also did could not handle constant arguments, since they cause an extra MOV immediate to be generated (since we haven't run constant propagation, there are more than the