Re: [Mesa-dev] [PATCH 09/10] anv: Implement VK_ANDROID_native_buffer (v9)

2017-10-16 Thread Jason Ekstrand
I made some fairly straightforward comments. with that, and the squash you sent, 1-6 and 8-10 are Reviewed-by: Jason Ekstrand I'd like to see the respin of patch 7 but I fully expect to give it my R-B almost immediately. --Jason On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace wrote: > This i

Re: [Mesa-dev] [PATCH 09/10] anv: Implement VK_ANDROID_native_buffer (v9)

2017-10-16 Thread Chad Versace
On Mon 16 Oct 2017, Kristian Høgsberg wrote: > On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace > wrote: > > v9: > > - Isolate as much Android code as possible, moving it from anv_image.c > > to anv_android.c. Connect the files with anv_image_from_gralloc(). > > Remove VkNativeBufferANDR

Re: [Mesa-dev] [PATCH 09/10] anv: Implement VK_ANDROID_native_buffer (v9)

2017-10-16 Thread Kristian Høgsberg
On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace wrote: > This implementation is correct (afaict), but takes two shortcuts > regarding the import/export of Android sync fds. > > Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync > fd into a VkSemaphore or VkFence, the driver i

[Mesa-dev] [PATCH 09/10] anv: Implement VK_ANDROID_native_buffer (v9)

2017-10-16 Thread Chad Versace
This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply blocks on the sync fd, then puts the VkSemaphore