Re: [Mesa-dev] [PATCH 08/64] i965/blorp: Only set src_z for gen8+ 3D textures

2016-06-22 Thread Chad Versace
On Tue 21 Jun 2016, Pohjolainen, Topi wrote: > On Mon, Jun 20, 2016 at 08:52:50PM -0700, Kenneth Graunke wrote: > > On Friday, June 17, 2016 4:55:41 PM PDT Jason Ekstrand wrote: > > > On Thu, Jun 16, 2016 at 10:08 AM, Chad Versace > > > wrote: > > > > > > > On Sat 11 Jun 2016, Jason Ekstrand wrot

Re: [Mesa-dev] [PATCH 08/64] i965/blorp: Only set src_z for gen8+ 3D textures

2016-06-21 Thread Pohjolainen, Topi
On Tue, Jun 21, 2016 at 03:51:15PM +0300, Pohjolainen, Topi wrote: > On Mon, Jun 20, 2016 at 08:52:50PM -0700, Kenneth Graunke wrote: > > On Friday, June 17, 2016 4:55:41 PM PDT Jason Ekstrand wrote: > > > On Thu, Jun 16, 2016 at 10:08 AM, Chad Versace > > > wrote: > > > > > > > On Sat 11 Jun 201

Re: [Mesa-dev] [PATCH 08/64] i965/blorp: Only set src_z for gen8+ 3D textures

2016-06-21 Thread Pohjolainen, Topi
On Mon, Jun 20, 2016 at 08:52:50PM -0700, Kenneth Graunke wrote: > On Friday, June 17, 2016 4:55:41 PM PDT Jason Ekstrand wrote: > > On Thu, Jun 16, 2016 at 10:08 AM, Chad Versace > > wrote: > > > > > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > > > Otherwise, we end up with a bogus value in the

Re: [Mesa-dev] [PATCH 08/64] i965/blorp: Only set src_z for gen8+ 3D textures

2016-06-20 Thread Kenneth Graunke
On Friday, June 17, 2016 4:55:41 PM PDT Jason Ekstrand wrote: > On Thu, Jun 16, 2016 at 10:08 AM, Chad Versace > wrote: > > > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > > Otherwise, we end up with a bogus value in the third component. On > > gen6-7 > > > where we always use 2D textures, this

Re: [Mesa-dev] [PATCH 08/64] i965/blorp: Only set src_z for gen8+ 3D textures

2016-06-17 Thread Jason Ekstrand
On Thu, Jun 16, 2016 at 10:08 AM, Chad Versace wrote: > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > Otherwise, we end up with a bogus value in the third component. On > gen6-7 > > where we always use 2D textures, this can cause problems if the > > SurfaceArray bit is set in the SURFACE_STATE.

Re: [Mesa-dev] [PATCH 08/64] i965/blorp: Only set src_z for gen8+ 3D textures

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > Otherwise, we end up with a bogus value in the third component. On gen6-7 > where we always use 2D textures, this can cause problems if the > SurfaceArray bit is set in the SURFACE_STATE. Enlighten me. Why does blorp use 3D surfaces on gen >= 8 but not

[Mesa-dev] [PATCH 08/64] i965/blorp: Only set src_z for gen8+ 3D textures

2016-06-11 Thread Jason Ekstrand
Otherwise, we end up with a bogus value in the third component. On gen6-7 where we always use 2D textures, this can cause problems if the SurfaceArray bit is set in the SURFACE_STATE. --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-