Re: [Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

2015-11-05 Thread Emil Velikov
On 3 November 2015 at 16:04, Emil Velikov wrote: >> @@ -1596,8 +1586,7 @@ vec4_visitor::lower_attributes_to_hw_regs(const int >> *attribute_map, >> reg.type = inst->dst.type; >> reg.writemask = inst->dst.writemask; >> >> -inst->dst.file = HW_REG; >> -inst->dst.f

Re: [Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

2015-11-03 Thread Matt Turner
On Tue, Nov 3, 2015 at 10:45 AM, Emil Velikov wrote: > I already have a few patches for what. I've even started exploring > which constructors we can nuke :-) > Can you post a branch somewhere so that I can rebase + send before you > get onto the next batch. Sure. It's the brw_reg branch of my tr

Re: [Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 17:55, Matt Turner wrote: > On Tue, Nov 3, 2015 at 8:04 AM, Emil Velikov wrote: >> On 3 November 2015 at 00:29, Matt Turner wrote: >> >> Please add a bit of commit message - "Mostly unused as of last commit. >> Fold the remaining cases (GRF only?) to use the base brw_reg st

Re: [Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

2015-11-03 Thread Matt Turner
On Tue, Nov 3, 2015 at 8:04 AM, Emil Velikov wrote: > On 3 November 2015 at 00:29, Matt Turner wrote: > > Please add a bit of commit message - "Mostly unused as of last commit. > Fold the remaining cases (GRF only?) to use the base brw_reg struct." > or anything else that you feel is appropriate.

Re: [Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: Please add a bit of commit message - "Mostly unused as of last commit. Fold the remaining cases (GRF only?) to use the base brw_reg struct." or anything else that you feel is appropriate. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

2015-11-02 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 93 +- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 9 +- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 +- src/mesa/drivers/dri/i965/brw_ir_fs.h | 4 +- src/mesa/drivers/dri/i965/brw_ir_v