Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-12 Thread Ben Widawsky
On 17-01-12 14:33:01, Daniel Stone wrote: On 12 January 2017 at 14:32, Daniel Stone wrote: If allocated, this image is just leaked, along with its reference on the BO. Same problem in gbm_dri_bo_get_handle_for_plane. ... and gbm_dri_bo_get_offset. Cheers, Daniel Does this work (compile tes

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-12 Thread Ben Widawsky
On 17-01-09 15:53:06, Jason Ekstrand wrote: On Mon, Jan 9, 2017 at 3:50 PM, Jason Ekstrand wrote: On Mon, Jan 2, 2017 at 6:36 PM, Ben Widawsky wrote: Signed-off-by: Ben Widawsky Reviewed-by: Eric Engestrom Acked-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 26 ++

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-12 Thread Daniel Stone
Hi, On 3 January 2017 at 02:36, Ben Widawsky wrote: > static uint32_t > gbm_dri_bo_get_stride(struct gbm_bo *_bo, int plane) > { > - return _bo->stride; > + struct gbm_dri_device *dri = gbm_dri_device(_bo->gbm); > + struct gbm_dri_bo *bo = gbm_dri_bo(_bo); > + __DRIimage *image; > +

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-12 Thread Daniel Stone
On 12 January 2017 at 14:32, Daniel Stone wrote: > If allocated, this image is just leaked, along with its reference on > the BO. Same problem in gbm_dri_bo_get_handle_for_plane. ... and gbm_dri_bo_get_offset. Cheers, Daniel ___ mesa-dev mailing list m

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-12 Thread Daniel Stone
Hi Ben, On 3 January 2017 at 02:36, Ben Widawsky wrote: > static uint32_t > gbm_dri_bo_get_stride(struct gbm_bo *_bo, int plane) > { > - return _bo->stride; > + struct gbm_dri_device *dri = gbm_dri_device(_bo->gbm); > + struct gbm_dri_bo *bo = gbm_dri_bo(_bo); > + __DRIimage *image; >

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-09 Thread Jason Ekstrand
On Mon, Jan 9, 2017 at 3:50 PM, Jason Ekstrand wrote: > On Mon, Jan 2, 2017 at 6:36 PM, Ben Widawsky wrote: > >> Signed-off-by: Ben Widawsky >> Reviewed-by: Eric Engestrom >> Acked-by: Daniel Stone >> --- >> src/gbm/backends/dri/gbm_dri.c | 26 +- >> src/gbm/gbm-symbo

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-09 Thread Jason Ekstrand
On Mon, Jan 2, 2017 at 6:36 PM, Ben Widawsky wrote: > Signed-off-by: Ben Widawsky > Reviewed-by: Eric Engestrom > Acked-by: Daniel Stone > --- > src/gbm/backends/dri/gbm_dri.c | 26 +- > src/gbm/gbm-symbols-check | 1 + > src/gbm/main/gbm.c | 15 +

[Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-02 Thread Ben Widawsky
Signed-off-by: Ben Widawsky Reviewed-by: Eric Engestrom Acked-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 26 +- src/gbm/gbm-symbols-check | 1 + src/gbm/main/gbm.c | 15 ++- src/gbm/main/gbm.h | 3 +++ 4 files changed