Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-24 Thread Francisco Jerez
Jason Ekstrand writes: > On Jul 24, 2015 8:02 AM, "Francisco Jerez" wrote: >> >> Jason Ekstrand writes: >> >> > On Fri, Jul 24, 2015 at 7:39 AM, Francisco Jerez > wrote: >> >> Jason Ekstrand writes: >> >> >> >>> On Jul 24, 2015 4:00 AM, "Francisco Jerez" > wrote: >> >> Jason Ekstra

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-24 Thread Jason Ekstrand
On Jul 24, 2015 8:02 AM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > On Fri, Jul 24, 2015 at 7:39 AM, Francisco Jerez wrote: > >> Jason Ekstrand writes: > >> > >>> On Jul 24, 2015 4:00 AM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > Ok, I've loo

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-24 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, Jul 24, 2015 at 7:39 AM, Francisco Jerez > wrote: >> Jason Ekstrand writes: >> >>> On Jul 24, 2015 4:00 AM, "Francisco Jerez" wrote: Jason Ekstrand writes: > Ok, I've looked through this again and convinced myself that it's > *mostly*

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-24 Thread Jason Ekstrand
On Fri, Jul 24, 2015 at 7:39 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Jul 24, 2015 4:00 AM, "Francisco Jerez" wrote: >>> >>> Jason Ekstrand writes: >>> >>> > Ok, I've looked through this again and convinced myself that it's >>> > *mostly* correct. I am a bit skeptical of the

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-24 Thread Francisco Jerez
Jason Ekstrand writes: > On Jul 24, 2015 4:00 AM, "Francisco Jerez" wrote: >> >> Jason Ekstrand writes: >> >> > Ok, I've looked through this again and convinced myself that it's >> > *mostly* correct. I am a bit skeptical of the address swizzling for >> > Y-major tiling. >> > >> > I've also in

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-24 Thread Jason Ekstrand
On Jul 24, 2015 4:00 AM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > Ok, I've looked through this again and convinced myself that it's > > *mostly* correct. I am a bit skeptical of the address swizzling for > > Y-major tiling. > > > > I've also included some comments that I'd like

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-24 Thread Francisco Jerez
Jason Ekstrand writes: > Ok, I've looked through this again and convinced myself that it's > *mostly* correct. I am a bit skeptical of the address swizzling for > Y-major tiling. > > I've also included some comments that I'd like to see added (assuming > they're correct). Sometimes it's easier

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-23 Thread Michael Schellenberger Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Am 21.07.2015 um 18:38 schrieb Francisco Jerez: > Define a function to calculate the memory address of the image > location given by a vector of coordinates. This is required in > cases where we need to fall back to untyped surface access, which

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-23 Thread Jason Ekstrand
Ok, I've looked through this again and convinced myself that it's *mostly* correct. I am a bit skeptical of the address swizzling for Y-major tiling. I've also included some comments that I'd like to see added (assuming they're correct). Sometimes it's easier to write helpful comments if the per

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-23 Thread Chad Versace
On Wed 22 Jul 2015, Jason Ekstrand wrote: > This needs a *lot* more commentary. These calculations are extremely > tricky and there are almost no comments. For instance, you are > turning a 2D offset on a tiled surface into a new 2D address into the > raw view of the surface. Nowhere do you expl

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > This needs a *lot* more commentary. These calculations are extremely > tricky and there are almost no comments. For instance, you are > turning a 2D offset on a tiled surface into a new 2D address into the > raw view of the surface. Nowhere do you explain what the "raw

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-22 Thread Jason Ekstrand
This needs a *lot* more commentary. These calculations are extremely tricky and there are almost no comments. For instance, you are turning a 2D offset on a tiled surface into a new 2D address into the raw view of the surface. Nowhere do you explain what the "raw" surface looks like and how its

[Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-21 Thread Francisco Jerez
Define a function to calculate the memory address of the image location given by a vector of coordinates. This is required in cases where we need to fall back to untyped surface access, which take a raw memory offset and know nothing about surface coordinates, type conversion or memory tiling and