Re: [Mesa-dev] [PATCH 07/12] nir: Don't use ffma in nir_lower_wpos_ytransform().

2016-05-22 Thread Michael Schellenberger Costa
Hi Kenneth, Am 19.05.2016 um 00:00 schrieb Kenneth Graunke: > ffma is an explicitly fused multiply add with higher precision. > The optimizer will take care of promoting mul/add to fma when > it's beneficial to do so. > > This fixes failures on Gen4-5 when using this pass, as those platforms > do

Re: [Mesa-dev] [PATCH 07/12] nir: Don't use ffma in nir_lower_wpos_ytransform().

2016-05-20 Thread Rob Clark
On Thu, May 19, 2016 at 9:41 PM, Kenneth Graunke wrote: > On Thursday, May 19, 2016 12:57:44 PM PDT Rob Clark wrote: >> On Wed, May 18, 2016 at 6:00 PM, Kenneth Graunke > wrote: >> > ffma is an explicitly fused multiply add with higher precision. >> > The optimizer will take care of promoting mul

Re: [Mesa-dev] [PATCH 07/12] nir: Don't use ffma in nir_lower_wpos_ytransform().

2016-05-19 Thread Matt Turner
On Thu, May 19, 2016 at 6:41 PM, Kenneth Graunke wrote: > On Thursday, May 19, 2016 12:57:44 PM PDT Rob Clark wrote: >> On Wed, May 18, 2016 at 6:00 PM, Kenneth Graunke > wrote: >> > ffma is an explicitly fused multiply add with higher precision. >> > The optimizer will take care of promoting mul

Re: [Mesa-dev] [PATCH 07/12] nir: Don't use ffma in nir_lower_wpos_ytransform().

2016-05-19 Thread Kenneth Graunke
On Thursday, May 19, 2016 12:57:44 PM PDT Rob Clark wrote: > On Wed, May 18, 2016 at 6:00 PM, Kenneth Graunke wrote: > > ffma is an explicitly fused multiply add with higher precision. > > The optimizer will take care of promoting mul/add to fma when > > it's beneficial to do so. > > > > This fix

Re: [Mesa-dev] [PATCH 07/12] nir: Don't use ffma in nir_lower_wpos_ytransform().

2016-05-19 Thread Rob Clark
On Wed, May 18, 2016 at 6:00 PM, Kenneth Graunke wrote: > ffma is an explicitly fused multiply add with higher precision. > The optimizer will take care of promoting mul/add to fma when > it's beneficial to do so. > > This fixes failures on Gen4-5 when using this pass, as those platforms > don't a

Re: [Mesa-dev] [PATCH 07/12] nir: Don't use ffma in nir_lower_wpos_ytransform().

2016-05-18 Thread Kenneth Graunke
On Thursday, May 19, 2016 8:39:45 AM PDT Michael Schellenberger Costa wrote: > Hi Kenneth, > > Am 19.05.2016 um 00:00 schrieb Kenneth Graunke: > > ffma is an explicitly fused multiply add with higher precision. > > The optimizer will take care of promoting mul/add to fma when > > it's beneficial t

[Mesa-dev] [PATCH 07/12] nir: Don't use ffma in nir_lower_wpos_ytransform().

2016-05-18 Thread Kenneth Graunke
ffma is an explicitly fused multiply add with higher precision. The optimizer will take care of promoting mul/add to fma when it's beneficial to do so. This fixes failures on Gen4-5 when using this pass, as those platforms don't actually implement fma(). Signed-off-by: Kenneth Graunke --- src/c