Re: [Mesa-dev] [PATCH 07/12] glsl: automake: remove custom AM_V_LEX/YACC

2015-07-17 Thread Timothy Arceri
On Fri, 2015-07-17 at 19:35 +0100, Emil Velikov wrote: > On 17 July 2015 at 19:02, Matt Turner wrote: > > On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov > > wrote: > > > We already use AM_V_GEN in src/mesa for lex/yacc. Plus we use the > > > generic macro for python generated sources as well. >

Re: [Mesa-dev] [PATCH 07/12] glsl: automake: remove custom AM_V_LEX/YACC

2015-07-17 Thread Emil Velikov
On 17 July 2015 at 19:02, Matt Turner wrote: > On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov > wrote: >> We already use AM_V_GEN in src/mesa for lex/yacc. Plus we use the >> generic macro for python generated sources as well. > > I'm in favor of removing "extras" when they cause problems, but I

Re: [Mesa-dev] [PATCH 07/12] glsl: automake: remove custom AM_V_LEX/YACC

2015-07-17 Thread Matt Turner
On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov wrote: > We already use AM_V_GEN in src/mesa for lex/yacc. Plus we use the > generic macro for python generated sources as well. I'm in favor of removing "extras" when they cause problems, but I'm not aware of any -- most of the lines git blame to th

[Mesa-dev] [PATCH 07/12] glsl: automake: remove custom AM_V_LEX/YACC

2015-07-17 Thread Emil Velikov
We already use AM_V_GEN in src/mesa for lex/yacc. Plus we use the generic macro for python generated sources as well. Cc: Matt Turner Signed-off-by: Emil Velikov --- src/glsl/Makefile.am | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/src/glsl/Makefile