Re: [Mesa-dev] [PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices

2013-07-31 Thread Jose Fonseca
- Original Message - > On Tue, Jul 30, 2013 at 8:46 PM, Paul Berry wrote: > > On 29 July 2013 11:09, Zack Rusin wrote: > >> > >> That looks wrong to me. We already account for the "other fields" in the > >> vertex_size. > > > > > > This patch came from Bryan Cain's original geometry shade

Re: [Mesa-dev] [PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices

2013-07-30 Thread Bryan Cain
On Tue, Jul 30, 2013 at 8:46 PM, Paul Berry wrote: > On 29 July 2013 11:09, Zack Rusin wrote: >> >> That looks wrong to me. We already account for the "other fields" in the >> vertex_size. > > > This patch came from Bryan Cain's original geometry shader patch series--I > admit I'm not familiar en

Re: [Mesa-dev] [PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices

2013-07-30 Thread Paul Berry
On 29 July 2013 11:09, Zack Rusin wrote: > That looks wrong to me. We already account for the "other fields" in the > vertex_size. > This patch came from Bryan Cain's original geometry shader patch series--I admit I'm not familiar enough with Gallium code to know how to fix it. Anyone want to st

Re: [Mesa-dev] [PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices

2013-07-29 Thread Zack Rusin
That looks wrong to me. We already account for the "other fields" in the vertex_size. - Original Message - > From: Bryan Cain > > Before, it accounted for the size of the vertices but not the other fields > in the vertex_header struct, which caused memory corruption. > --- > src/galliu

[Mesa-dev] [PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices

2013-07-28 Thread Paul Berry
From: Bryan Cain Before, it accounted for the size of the vertices but not the other fields in the vertex_header struct, which caused memory corruption. --- src/gallium/auxiliary/draw/draw_gs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_