Re: [Mesa-dev] [PATCH 06/17] glsl parser: handle interface block member qualifier

2013-05-13 Thread Jordan Justen
I agree with all your suggestions on this patch. With them, is this r-b you? -Jordan On Sun, Apr 21, 2013 at 11:31 AM, Kenneth Graunke wrote: > On 04/19/2013 12:35 PM, Jordan Justen wrote: >> >> An interface block member may specify the type: >> in { >> in vec4 in_var_with_qualifier; >> };

Re: [Mesa-dev] [PATCH 06/17] glsl parser: handle interface block member qualifier

2013-04-21 Thread Kenneth Graunke
On 04/19/2013 12:35 PM, Jordan Justen wrote: An interface block member may specify the type: in { in vec4 in_var_with_qualifier; }; When specified with the member, it must match the same type as interface block type. It can also omit the qualifier: uniform { vec4 uniform_var_without_q

[Mesa-dev] [PATCH 06/17] glsl parser: handle interface block member qualifier

2013-04-19 Thread Jordan Justen
An interface block member may specify the type: in { in vec4 in_var_with_qualifier; }; When specified with the member, it must match the same type as interface block type. It can also omit the qualifier: uniform { vec4 uniform_var_without_qualifier; }; When the type is not specified with