Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-21 Thread Matt Turner
On Wed, Jan 21, 2015 at 6:57 PM, Ian Romanick wrote: > On 01/21/2015 03:05 PM, Matt Turner wrote: >> On Wed, Jan 21, 2015 at 2:52 PM, Kenneth Graunke >> wrote: >>> On Wednesday, January 21, 2015 01:02:46 PM Matt Turner wrote: Okay, I changed the name, and in the process of thinking about th

Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-21 Thread Ian Romanick
On 01/21/2015 03:05 PM, Matt Turner wrote: > On Wed, Jan 21, 2015 at 2:52 PM, Kenneth Graunke > wrote: >> On Wednesday, January 21, 2015 01:02:46 PM Matt Turner wrote: >>> On Tue, Jan 20, 2015 at 12:11 AM, Kenneth Graunke >>> wrote: On Monday, January 19, 2015 03:31:05 PM Matt Turner wrote

Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-21 Thread Matt Turner
On Wed, Jan 21, 2015 at 3:19 PM, Kenneth Graunke wrote: > Okay, I see what you're doing now. It's definitely not what my > brw_negate_cmod function did. This is why you absolutely need > doxygen comments, ideally with an example. The functions for > (a cmp1 b) -> !(a cmp1 b) and (a cmp1 b) -> (

Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-21 Thread Kenneth Graunke
On Wednesday, January 21, 2015 03:05:03 PM Matt Turner wrote: > On Wed, Jan 21, 2015 at 2:52 PM, Kenneth Graunke > wrote: > > On Wednesday, January 21, 2015 01:02:46 PM Matt Turner wrote: > >> On Tue, Jan 20, 2015 at 12:11 AM, Kenneth Graunke > >> wrote: > >> > On Monday, January 19, 2015 03:31

Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-21 Thread Matt Turner
On Wed, Jan 21, 2015 at 2:52 PM, Kenneth Graunke wrote: > On Wednesday, January 21, 2015 01:02:46 PM Matt Turner wrote: >> On Tue, Jan 20, 2015 at 12:11 AM, Kenneth Graunke >> wrote: >> > On Monday, January 19, 2015 03:31:05 PM Matt Turner wrote: >> >> --- >> >> src/mesa/drivers/dri/i965/brw_eu

Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-21 Thread Kenneth Graunke
On Wednesday, January 21, 2015 01:02:46 PM Matt Turner wrote: > On Tue, Jan 20, 2015 at 12:11 AM, Kenneth Graunke > wrote: > > On Monday, January 19, 2015 03:31:05 PM Matt Turner wrote: > >> --- > >> src/mesa/drivers/dri/i965/brw_eu.c | 22 ++ > >> src/mesa/drivers/dri/i965/b

Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-21 Thread Matt Turner
On Tue, Jan 20, 2015 at 12:11 AM, Kenneth Graunke wrote: > On Monday, January 19, 2015 03:31:05 PM Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_eu.c | 22 ++ >> src/mesa/drivers/dri/i965/brw_eu.h | 1 + >> 2 files changed, 23 insertions(+) >> >> diff --git a/src

Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-20 Thread Kenneth Graunke
On Monday, January 19, 2015 03:31:05 PM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu.c | 22 ++ > src/mesa/drivers/dri/i965/brw_eu.h | 1 + > 2 files changed, 23 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu.c > b/src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

2015-01-19 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_eu.c | 22 ++ src/mesa/drivers/dri/i965/brw_eu.h | 1 + 2 files changed, 23 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/drivers/dri/i965/brw_eu.c index 9905972..9977eed 100644 --- a/src/mesa/drivers/dri/i965/brw_