Re: [Mesa-dev] [PATCH 06/13] nir: don't count removal of lcssa_phi as progress

2016-12-22 Thread Timothy Arceri
On Thu, 2016-12-22 at 11:58 -0800, Jason Ekstrand wrote: > I'm not actually sure that we need this anymore.  We never run > convert_to_lcssa unless we are about to make actual CF modifications > and, therefore, report progress.  I've got a patch running through > Jenkins now to find out.  I'm not s

Re: [Mesa-dev] [PATCH 06/13] nir: don't count removal of lcssa_phi as progress

2016-12-22 Thread Jason Ekstrand
On Thu, Dec 22, 2016 at 11:58 AM, Jason Ekstrand wrote: > I'm not actually sure that we need this anymore. We never run > convert_to_lcssa unless we are about to make actual CF modifications and, > therefore, report progress. I've got a patch running through Jenkins now > to find out. I'm not

Re: [Mesa-dev] [PATCH 06/13] nir: don't count removal of lcssa_phi as progress

2016-12-22 Thread Jason Ekstrand
I'm not actually sure that we need this anymore. We never run convert_to_lcssa unless we are about to make actual CF modifications and, therefore, report progress. I've got a patch running through Jenkins now to find out. I'm not strongly opposed to keeping it but I'd like to know if it's really

[Mesa-dev] [PATCH 06/13] nir: don't count removal of lcssa_phi as progress

2016-12-21 Thread Timothy Arceri
V2: - make the is_lcssa_phi bool const, suggested by Topi. --- src/compiler/nir/nir_opt_remove_phis.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_remove_phis.c b/src/compiler/nir/nir_opt_remove_phis.c index acaa6e1..99d5d35 100644 --- a/src/com

[Mesa-dev] [PATCH 06/13] nir: don't count removal of lcssa_phi as progress

2016-08-28 Thread Timothy Arceri
--- src/compiler/nir/nir_opt_remove_phis.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_remove_phis.c b/src/compiler/nir/nir_opt_remove_phis.c index ee92fbe..6d9e0ff 100644 --- a/src/compiler/nir/nir_opt_remove_phis.c +++ b/src/compiler/nir/nir_o