Re: [Mesa-dev] [PATCH 06/12] util: Add tests for fast integer division by constants

2018-10-10 Thread Jason Ekstrand
I just landed the first 6 patches as well as a fix for one intel compiler bug uncovered by the series. You can go ahead and rebase your former series. If you feel the need for a separate 32-bit version of compute_fast_udiv_info, I'll happily reivew the patch. --Jason On Mon, Oct 8, 2018 at 11:1

Re: [Mesa-dev] [PATCH 06/12] util: Add tests for fast integer division by constants

2018-10-08 Thread Dylan Baker
Quoting Jason Ekstrand (2018-10-05 21:10:14) > While I generally trust rediculousfish to have done his homework, we've > made some adjustments to suite the needs of mesa and it'd be good to ^ suit > test those. Also, there's no better plac

Re: [Mesa-dev] [PATCH 06/12] util: Add tests for fast integer division by constants

2018-10-08 Thread Jason Ekstrand
On Sat, Oct 6, 2018 at 1:52 PM Marek Olšák wrote: > With my comments addressed, patches 2 - 6 are: > > Reviewed-by: Marek Olšák > Thanks! Unfortunately, the tests require patch 1 so it'd be nice if that got review by someone. I'd also be happy to pull in someone else's more vetted code for la

Re: [Mesa-dev] [PATCH 06/12] util: Add tests for fast integer division by constants

2018-10-06 Thread Marek Olšák
With my comments addressed, patches 2 - 6 are: Reviewed-by: Marek Olšák Since I will need to compute the division terms during draw calls, I may need to switch the math to uint32_t for my case (e.g. via a C++ template). Marek On Sat, Oct 6, 2018 at 12:11 AM Jason Ekstrand wrote: >> While I ge

Re: [Mesa-dev] [PATCH 06/12] util: Add tests for fast integer division by constants

2018-10-06 Thread Marek Olšák
On Sat, Oct 6, 2018 at 12:11 AM Jason Ekstrand wrote: > > While I generally trust rediculousfish to have done his homework, we've > made some adjustments to suite the needs of mesa and it'd be good to > test those. Also, there's no better place than unit tests to clearly > document the different

[Mesa-dev] [PATCH 06/12] util: Add tests for fast integer division by constants

2018-10-05 Thread Jason Ekstrand
While I generally trust rediculousfish to have done his homework, we've made some adjustments to suite the needs of mesa and it'd be good to test those. Also, there's no better place than unit tests to clearly document the different edge cases of the different methods. --- configure.ac