Re: [Mesa-dev] [PATCH 05/24] i965: Reorganize brw_reg fields.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 17:27, Matt Turner wrote: > On Tue, Nov 3, 2015 at 2:38 AM, Emil Velikov wrote: >> On 3 November 2015 at 00:29, Matt Turner wrote: >>> Put fields that are meaningless with an immediate in the same storage >>> with the immediate. >> There is something funky here. Should it b

Re: [Mesa-dev] [PATCH 05/24] i965: Reorganize brw_reg fields.

2015-11-03 Thread Matt Turner
On Tue, Nov 3, 2015 at 2:38 AM, Emil Velikov wrote: > On 3 November 2015 at 00:29, Matt Turner wrote: >> Put fields that are meaningless with an immediate in the same storage >> with the immediate. > There is something funky here. Should it be > > "Put fields that are meaningless _without_ an imm

Re: [Mesa-dev] [PATCH 05/24] i965: Reorganize brw_reg fields.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > Put fields that are meaningless with an immediate in the same storage > with the immediate. There is something funky here. Should it be "Put fields that are meaningless _without_ an immediate in the same storage _as_ the immediate..." -Emil _

[Mesa-dev] [PATCH 05/24] i965: Reorganize brw_reg fields.

2015-11-02 Thread Matt Turner
Put fields that are meaningless with an immediate in the same storage with the immediate. This leaves fields type, file, nr, subnr in the first dword where there's now extra room for expansion. --- src/mesa/drivers/dri/i965/brw_reg.h | 16 1 file changed, 8 insertions(+), 8 deleti