Looks good to me.
Reviewed-by: Laura Ekstrand
On Mon, Feb 23, 2015 at 6:47 AM, Martin Peres
wrote:
> v2: Review from Laura Ekstrand
> - give more helpful error messages
> - factor the lookup code for the xfb and objBuf
> - replace some already-existing tabs with spaces
> - add comments to expl
v2: Review from Laura Ekstrand
- give more helpful error messages
- factor the lookup code for the xfb and objBuf
- replace some already-existing tabs with spaces
- add comments to explain the cases where xfb == 0 or buffer == 0
- fix the condition for binding the transform buffer or not
v3: Revie
On 21/02/15 02:25, Laura Ekstrand wrote:
You still seem to be confused about the names of internal functions.
If a function exists outside of its "class," (ie. is extern-ed from a
*.h file), it should have the "_mesa" in front. If a function exists
purely inside of a *.c file, it should be st
You still seem to be confused about the names of internal functions. If a
function exists outside of its "class," (ie. is extern-ed from a *.h file),
it should have the "_mesa" in front. If a function exists purely inside of
a *.c file, it should be static and not have "_mesa."
Since _mesa_looku
v2: Review from Laura Ekstrand
- give more helpful error messages
- factor the lookup code for the xfb and objBuf
- replace some already-existing tabs with spaces
- add comments to explain the cases where xfb == 0 or buffer == 0
- fix the condition for binding the transform buffer or not
v3: Revie
