Re: [Mesa-dev] [PATCH 05/12] i965/fs: Use offset a lot more places

2014-09-23 Thread Kenneth Graunke
On Tuesday, September 23, 2014 10:50:08 AM Matt Turner wrote: > On Mon, Sep 22, 2014 at 1:42 PM, Matt Turner wrote: > > On Mon, Sep 22, 2014 at 1:40 PM, Jason Ekstrand > > wrote: > >> On Fri, Sep 19, 2014 at 5:34 PM, Matt Turner wrote: > >>> On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand > >>

Re: [Mesa-dev] [PATCH 05/12] i965/fs: Use offset a lot more places

2014-09-23 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/12] i965/fs: Use offset a lot more places

2014-09-23 Thread Matt Turner
On Mon, Sep 22, 2014 at 1:42 PM, Matt Turner wrote: > On Mon, Sep 22, 2014 at 1:40 PM, Jason Ekstrand wrote: >> On Fri, Sep 19, 2014 at 5:34 PM, Matt Turner wrote: >>> On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand >>> > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp >>> > b/src/mesa/driver

Re: [Mesa-dev] [PATCH 05/12] i965/fs: Use offset a lot more places

2014-09-22 Thread Matt Turner
On Mon, Sep 22, 2014 at 1:40 PM, Jason Ekstrand wrote: > On Fri, Sep 19, 2014 at 5:34 PM, Matt Turner wrote: >> On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand >> > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp >> > b/src/mesa/drivers/dri/i965/brw_fs.cpp >> > index af8c087..ea91705 100644 >>

Re: [Mesa-dev] [PATCH 05/12] i965/fs: Use offset a lot more places

2014-09-22 Thread Jason Ekstrand
On Fri, Sep 19, 2014 at 5:34 PM, Matt Turner wrote: > On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand > wrote: > > We have this wonderful offset() function for advancing registers, but > we're > > not using it. Using offset() allows us to do some sanity checking and > > avoid manually touching

Re: [Mesa-dev] [PATCH 05/12] i965/fs: Use offset a lot more places

2014-09-19 Thread Matt Turner
On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand wrote: > We have this wonderful offset() function for advancing registers, but we're > not using it. Using offset() allows us to do some sanity checking and > avoid manually touching fs_reg::reg_offset. In a few commits, we will make > offset do ev

[Mesa-dev] [PATCH 05/12] i965/fs: Use offset a lot more places

2014-09-19 Thread Jason Ekstrand
We have this wonderful offset() function for advancing registers, but we're not using it. Using offset() allows us to do some sanity checking and avoid manually touching fs_reg::reg_offset. In a few commits, we will make offset do even more nifty things for us. Signed-off-by: Jason Ekstrand ---