Re: [Mesa-dev] [PATCH 04/32] glsl: Refactor uniform block parser rules.

2013-01-24 Thread Chad Versace
Patches 1-4 are Reviewed-by: Chad Versace I'm still working through the others. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 04/32] glsl: Refactor uniform block parser rules.

2013-01-23 Thread Carl Worth
Ian Romanick writes: > From: Kenneth Graunke > > The existing code has a lot of duplication; the only difference between > the two cases is whether we merge in an additional layout qualifier. I'm always in favor of a simpler grammar. Thanks! Reviewed-by: Carl Worth -Carl -- carl.d.wo...@int

[Mesa-dev] [PATCH 04/32] glsl: Refactor uniform block parser rules.

2013-01-22 Thread Ian Romanick
From: Kenneth Graunke The existing code has a lot of duplication; the only difference between the two cases is whether we merge in an additional layout qualifier. Apparently creating a layout_qualifieropt rule that can be empty causes a lot of conflicts and confusion. However, refactoring out t