Re: [Mesa-dev] [PATCH 04/26] python: Better check for keys in dicts

2018-07-06 Thread Ian Romanick
I don't think I knew about the "in" operator when I wrote that code... a lot of it is pretty old, so it may not have even existed in 2005. :) This patch is Reviewed-by: Ian Romanick On 07/06/2018 03:15 AM, Mathieu Bridon wrote: > Python 3 lost the dict.has_key() method. Instead it requires usin

[Mesa-dev] [PATCH 04/26] python: Better check for keys in dicts

2018-07-06 Thread Mathieu Bridon
Python 3 lost the dict.has_key() method. Instead it requires using the "in" operator. This is also compatible with Python 2. Signed-off-by: Mathieu Bridon --- src/mapi/glapi/gen/glX_XML.py| 2 +- src/mapi/glapi/gen/glX_proto_send.py | 2 +- src/mapi/glapi/gen/glX_proto_size.py | 18 ++

Re: [Mesa-dev] [PATCH 04/26] python: Better check for keys in dicts

2018-07-05 Thread Dylan Baker
With the changes Eric mentioned (moving the two hunks in the wrong patch to the right one), Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-05 06:17:35) > Python 3 lost the dict.has_key() method. Instead it requires using the > "in" operator. > > This is also compatible with Python 2. >

Re: [Mesa-dev] [PATCH 04/26] python: Better check for keys in dicts

2018-07-05 Thread Eric Engestrom
On Thursday, 2018-07-05 15:17:35 +0200, Mathieu Bridon wrote: > Python 3 lost the dict.has_key() method. Instead it requires using the > "in" operator. > > This is also compatible with Python 2. > > Signed-off-by: Mathieu Bridon > --- > src/mapi/glapi/gen/glX_XML.py| 2 +- > src/mapi/g

Re: [Mesa-dev] [PATCH 04/26] python: Better check for keys in dicts

2018-07-05 Thread Eric Engestrom
On Thursday, 2018-07-05 15:17:35 +0200, Mathieu Bridon wrote: > Python 3 lost the dict.has_key() method. Instead it requires using the > "in" operator. > > This is also compatible with Python 2. > > Signed-off-by: Mathieu Bridon Reviewed-by: Eric Engestrom > --- > src/mapi/glapi/gen/glX_XML.

[Mesa-dev] [PATCH 04/26] python: Better check for keys in dicts

2018-07-05 Thread Mathieu Bridon
Python 3 lost the dict.has_key() method. Instead it requires using the "in" operator. This is also compatible with Python 2. Signed-off-by: Mathieu Bridon --- src/mapi/glapi/gen/glX_XML.py| 2 +- src/mapi/glapi/gen/glX_proto_send.py | 2 +- src/mapi/glapi/gen/glX_proto_size.py | 18 ++