Re: [Mesa-dev] [PATCH 04/16] glsl: Expand constant_util

2014-11-19 Thread Ian Romanick
On 11/16/2014 07:41 PM, Matt Turner wrote: > On Sun, Nov 16, 2014 at 5:51 PM, Thomas Helland > wrote: >> Add functions: >> is_greater_than_one >> is_less_than_zero >> >> Add variations like greater_than_or_equal_zero. >> --- >> This is not ideal computation-wise, as we are doing two >> iterati

Re: [Mesa-dev] [PATCH 04/16] glsl: Expand constant_util

2014-11-16 Thread Matt Turner
On Sun, Nov 16, 2014 at 5:51 PM, Thomas Helland wrote: > Add functions: > is_greater_than_one > is_less_than_zero > > Add variations like greater_than_or_equal_zero. > --- > This is not ideal computation-wise, as we are doing two > iterations instead of one. The question is wether or not > the

[Mesa-dev] [PATCH 04/16] glsl: Expand constant_util

2014-11-16 Thread Thomas Helland
Add functions: is_greater_than_one is_less_than_zero Add variations like greater_than_or_equal_zero. --- This is not ideal computation-wise, as we are doing two iterations instead of one. The question is wether or not the extra code is worth the duplicaton. --- src/glsl/ir_constant_util.h | 5